Re: [patch] e1000=y && e1000e=m regression fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Wilcox <matthew@...>
Cc: Linus Torvalds <torvalds@...>, Christoph Hellwig <hch@...>, Kok, Auke <auke-jan.h.kok@...>, Ingo Molnar <mingo@...>, Jeff Garzik <jeff@...>, Linux Kernel Mailing List <linux-kernel@...>, NetDev <netdev@...>, e1000-list <e1000-devel@...>, linux-pci maillist <linux-pci@...>, Andrew Morton <akpm@...>, David S. Miller <davem@...>, Jesse Brandeburg <jesse.brandeburg@...>, Ronciak, John <john.ronciak@...>, Allan, Bruce W <bruce.w.allan@...>, Greg KH <greg@...>, Arjan van de Ven <arjan@...>, Rafael J. Wysocki <rjw@...>
Date: Friday, April 11, 2008 - 3:25 pm

On Fri, Apr 11, 2008 at 01:01:28PM -0600, Matthew Wilcox wrote:

I don't think this will happen like that. People will simply think as
usual "ah, they have added support for new hardware, but since everything
in my machine was supported, I don't need it".

I think that the correct solution to help people is not at build time,
but at run time. The e1000 driver should just *check* if there are PCI-IDs
that it used to manage and that it does not anymore, for unclaimed devices,
and report a warning message clearly indicating that these devices are not
handled anymore and that for this, the user must load e1000e. It will :

  a) help people know what to load if they need to update modprobe.conf
  b) just require a new "make menuconfig;make modules" after the poor guy
     has been caught.

It's not a problem to have to tweak the config and reboot several times,
provided that the user is guided. Almost none of us has ever blindly
upgraded without a few post-boot adjustments.


Here if people don't know, they will reply "no" too.


I'm pretty sure it's PCI-E, because Linus got caught first ;-) But of
course, that should not be an accepted guess method.

Willy

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
showing which hardware is unclaimed, Rick Jones, (Tue Apr 8, 4:13 pm)
Re: showing which hardware is unclaimed, Martin Mares, (Tue Apr 8, 4:35 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:12 pm)
Re: [regression] e1000e broke e1000, Matthew Wilcox, (Tue Apr 8, 4:20 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:39 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:35 pm)
Re: [regression] e1000e broke e1000, Martin Mares, (Tue Apr 8, 4:36 pm)
Re: [regression] e1000e broke e1000, Bill Davidsen, (Wed Apr 9, 8:52 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 4:59 am)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 3:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:06 pm)
Re: [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:31 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Wed Apr 9, 3:12 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Wed Apr 9, 3:33 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 7:30 am)
Re: [regression] e1000e broke e1000, Chris Friesen, (Fri Apr 11, 11:40 am)
Re: [regression] e1000e broke e1000, Willy Tarreau, (Fri Apr 11, 3:29 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:19 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:33 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:56 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Chris Friesen, (Thu Apr 10, 5:20 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Thu Apr 10, 3:27 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 7:26 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 7:36 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 8:16 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Martin Mares, (Fri Apr 11, 1:10 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 12:45 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:34 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 6:06 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 7:00 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 7:43 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Sun Apr 13, 5:13 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ondrej Zary, (Sun Apr 13, 5:34 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Sat Apr 12, 9:07 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:15 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 6:21 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:05 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 1:53 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 2:51 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Krzysztof Halasa, (Fri Apr 11, 4:22 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:29 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:01 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:21 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Willy Tarreau, (Fri Apr 11, 3:25 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:38 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Philip Craig, (Thu Apr 10, 8:46 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Randy Dunlap, (Thu Apr 10, 5:44 pm)
Re: [E1000-devel] [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:47 pm)