Re: [patch] e1000=y && e1000e=m regression fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Christoph Hellwig <hch@...>, Kok, Auke <auke-jan.h.kok@...>, Ingo Molnar <mingo@...>, Jeff Garzik <jeff@...>, Linux Kernel Mailing List <linux-kernel@...>, NetDev <netdev@...>, e1000-list <e1000-devel@...>, linux-pci maillist <linux-pci@...>, Andrew Morton <akpm@...>, David S. Miller <davem@...>, Jesse Brandeburg <jesse.brandeburg@...>, Ronciak, John <john.ronciak@...>, Allan, Bruce W <bruce.w.allan@...>, Greg KH <greg@...>, Arjan van de Ven <arjan@...>, Rafael J. Wysocki <rjw@...>
Date: Friday, April 11, 2008 - 3:01 pm

On Fri, Apr 11, 2008 at 11:51:07AM -0700, Linus Torvalds wrote:

We only support people keeping their old configs after they run 'make
oldconfig', right?  At which point they'd be prompted for E1000_SUPPORT.
Presumably they'd think "That's odd.  I'm sure I had that selected
before", then select it.  Then oldconfig skips over CONFIG_E1000 because
it already knows the answer to that one and they're prompted with a
question about PCIe support.  Now something is clearly strange.  Perhaps
they look at the help text at this point and it says to go with 'Y' or
'M' if they're not sure.

That's the most important bit of help texts for me.  Do I want Control
Groups?  Will my machine break if I don't select them?  I have no idea
what a 'process cgroup subsystem' is, and I don't care.  But the help
text tells me I can say "n" and nothing will break.


I quite agree.  I have no idea either.  All I know is that my ICH9 box
didn't work until e1000e was released ;-)

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
showing which hardware is unclaimed, Rick Jones, (Tue Apr 8, 4:13 pm)
Re: showing which hardware is unclaimed, Martin Mares, (Tue Apr 8, 4:35 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:12 pm)
Re: [regression] e1000e broke e1000, Matthew Wilcox, (Tue Apr 8, 4:20 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:39 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:35 pm)
Re: [regression] e1000e broke e1000, Martin Mares, (Tue Apr 8, 4:36 pm)
Re: [regression] e1000e broke e1000, Bill Davidsen, (Wed Apr 9, 8:52 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 4:59 am)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 3:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:06 pm)
Re: [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:31 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Wed Apr 9, 3:12 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Wed Apr 9, 3:33 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 7:30 am)
Re: [regression] e1000e broke e1000, Chris Friesen, (Fri Apr 11, 11:40 am)
Re: [regression] e1000e broke e1000, Willy Tarreau, (Fri Apr 11, 3:29 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:19 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:33 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:56 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Chris Friesen, (Thu Apr 10, 5:20 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Thu Apr 10, 3:27 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 7:26 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 7:36 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 8:16 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Martin Mares, (Fri Apr 11, 1:10 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 12:45 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:34 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 6:06 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 7:00 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 7:43 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Sun Apr 13, 5:13 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ondrej Zary, (Sun Apr 13, 5:34 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Sat Apr 12, 9:07 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:15 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 6:21 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:05 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 1:53 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 2:51 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Krzysztof Halasa, (Fri Apr 11, 4:22 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:29 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:01 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:21 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Willy Tarreau, (Fri Apr 11, 3:25 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:38 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Philip Craig, (Thu Apr 10, 8:46 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Randy Dunlap, (Thu Apr 10, 5:44 pm)
Re: [E1000-devel] [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:47 pm)