Home » Mailing list archives » linux-kernel » 2008 » April » 11

Re: [PATCH] Fix compile breakage caused by asmlinkage_protect

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Heiko Carstens <heiko.carstens@...>
Cc: Andrew Morton <akpm@...>, Jakub Jelinek <jakub@...>, Dave Jones <davej@...>, <drepper@...>, <mingo@...>, <tglx@...>, <linux-kernel@...>, Roland McGrath <roland@...>, Martin Schwidefsky <schwidefsky@...>
Subject: Re: [PATCH] Fix compile breakage caused by asmlinkage_protect
Date: Friday, April 11, 2008 - 10:46 am

On Fri, 11 Apr 2008, Heiko Carstens wrote:

Ok, that's just _odd_.


There are no side effects on asm code. It just adds a #define that 
obviously won't be used.

Is the s390 assembler using some strange C pre-processor that is different 
from the main C preprocessor and doesn't understand this pattern?

I really think you should fix *that*, because otherwise you'll hit these 
kinds of bugs occasionally. There aren't that many asm files, it's not 
worth it optimizing them to use some faster-but-stupider preprocessor.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] asmlinkage_protect replaces prevent_tail_call, Roland McGrath, (Thu Apr 10, 6:37 pm)
[PATCH] Fix compile breakage caused by asmlinkage_protect, Heiko Carstens, (Fri Apr 11, 7:46 am)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Linus Torvalds, (Fri Apr 11, 10:46 am)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Al Viro, (Fri Apr 11, 11:11 am)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Linus Torvalds, (Fri Apr 11, 11:25 am)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Kyle McMartin, (Fri Apr 11, 11:37 am)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Martin Schwidefsky, (Fri Apr 11, 12:03 pm)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Adrian Bunk, (Fri Apr 11, 1:09 pm)
Re: [PATCH] Fix compile breakage caused by asmlinkage_protect, Jakub Jelinek, (Fri Apr 11, 11:06 am)