Re: [patch] e1000=y && e1000e=m regression fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Philip Craig
Date: Thursday, April 10, 2008 - 5:46 pm

Kok, Auke wrote:

One problem is that the meaning of E1000 has been changed.  It covers less
hardware than it used to.

You could add a new option to control the e1000 driver, and make E1000 set
both this new option and E1000E.  Thus it will always cover at least all
the IDs that the original e1000 driver handled.

config E1000
	tristate "Both Intel(R) PRO/1000 Gigabit Ethernet support"
	depends on PCI

config E1000_ONLY
	tristate "Intel(R) PRO/1000 Gigabit Ethernet support" if E1000=n
	default E1000
	depends on PCI

config E1000E
	tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" if E1000=n
	default E1000
	depends on PCI

The E1000E prompt restriction is required to upgrade existing E1000=y,
E1000E=m configs to E1000E=y.

But it will also upgrade E1000=y/m,E1000E=n to E1000E=y/m, which may not
always be right.

This still doesn't solve any problems with loading modules for E1000=m.
Loading the e1000 module will still load support for less than it used to.
(Because make oldconfig is not the answer ;-)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e ..., Brandeburg, Jesse, (Tue Apr 8, 12:43 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 12:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:06 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 1:12 pm)
showing which hardware is unclaimed, Rick Jones, (Tue Apr 8, 1:13 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 1:19 pm)
Re: [regression] e1000e broke e1000, Matthew Wilcox, (Tue Apr 8, 1:20 pm)
Re: [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 1:31 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:33 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:35 pm)
Re: showing which hardware is unclaimed, Martin Mares, (Tue Apr 8, 1:35 pm)
Re: [regression] e1000e broke e1000, Martin Mares, (Tue Apr 8, 1:36 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 1:39 pm)
Re: [E1000-devel] [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 1:47 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 1:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Wed Apr 9, 12:12 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Wed Apr 9, 12:33 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Wed Apr 9, 12:50 pm)
Re: [regression] e1000e broke e1000, Bill Davidsen, (Wed Apr 9, 5:52 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Thu Apr 10, 12:27 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Chris Friesen, (Thu Apr 10, 2:20 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Randy Dunlap, (Thu Apr 10, 2:44 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Philip Craig, (Thu Apr 10, 5:46 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Andi Kleen, (Fri Apr 11, 12:54 am)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 1:59 am)
Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 4:26 am)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 4:30 am)
Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 4:36 am)
Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 5:16 am)
Re: [regression] e1000e broke e1000, Chris Friesen, (Fri Apr 11, 8:40 am)
Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 9:45 am)
Re: [patch] e1000=y && e1000e=m regression fix, Martin Mares, (Fri Apr 11, 10:10 am)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 10:34 am)
Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 10:53 am)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 11:51 am)
Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 12:01 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Willy Tarreau, (Fri Apr 11, 12:25 pm)
Re: [regression] e1000e broke e1000, Willy Tarreau, (Fri Apr 11, 12:29 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 12:38 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:21 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Krzysztof Halasa, (Fri Apr 11, 1:22 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:29 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 3:06 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 3:21 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:00 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 4:05 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 4:15 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 4:43 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Sat Apr 12, 6:07 am)
Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Sun Apr 13, 2:13 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Ondrej Zary, (Sun Apr 13, 2:34 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Mon Jun 9, 12:24 pm)