[PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux1394-devel@...>
Cc: <linux-kernel@...>
Date: Thursday, April 10, 2008 - 6:49 pm

Fix harmless but irritating off-by-one bug in patch "firewire: debug
interrupt events".  Should be folded into that one.

See OHCI 1.1 clause 8.7.1.4.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/fw-ohci.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
 	if (unlikely(evt >= ARRAY_SIZE(evts)))
 			evt = 0x1f;
 
-	if (header[0] == ~header[1]) {
+	if (header[1] == ~header[2]) {
 		printk(KERN_DEBUG "A%c %s, %s, %08x\n",
-		       dir, evts[evt], phys[header[0] >> 30 & 0x3],
-		       header[0]);
+		       dir, evts[evt], phys[header[1] >> 30 & 0x3],
+		       header[1]);
 		return;
 	}
 

-- 
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] firewire: fw-ohci: fix debug logging of phy pack..., Stefan Richter, (Thu Apr 10, 6:49 pm)