Re: [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000)

view
thread

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Linus Torvalds <torvalds@...>

Cc: Frans Pop <elendil@...>, Ingo Molnar <mingo@...>, <jeff@...>, <matthew@...>, <auke-jan.h.kok@...>, <linux-kernel@...>, <netdev@...>, <e1000-devel@...>, <linux-pci@...>, <akpm@...>, <davem@...>, <jesse.brandeburg@...>, <john.ronciak@...>, <bruce.w.allan@...>, <greg@...>, <arjan@...>, <rjw@...>

Subject: Re: [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000)

Date: Thursday, April 10, 2008 - 5:35 pm

Linus Torvalds <torvalds@linux-foundation.org> writes:

quoted text> No it wouldn't, not when the driver we used forever suddenly stopped 
> supporting them.

In this case e1000 stops supporting them only if you enable e1000e
too. No e1000e, e1000 still does those IDs. For now, if I understand
it correctly. And it seems to print a warning.

So it doesn't work if you make e1000e a module and don't load it.

quoted text> And no, I'm not talking about some theoretical "this could happen" thing. 
> I hit exactly that with commit
> 040babf9d84e7010c457e9ce69e9eb1c27927c9e 

Right. Now it's a different situation, though.
-- 
Krzysztof Halasa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 t..., Ingo Molnar, (Tue Apr 8, 2:39 pm)

RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Brandeburg, Jesse, (Tue Apr 8, 3:43 pm)

Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Ingo Molnar, (Tue Apr 8, 3:59 pm)

Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Matthew Wilcox, (Tue Apr 8, 4:04 pm)

Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Ingo Molnar, (Tue Apr 8, 4:17 pm)

showing which hardware is unclaimed, Rick Jones, (Tue Apr 8, 4:13 pm)

Re: showing which hardware is unclaimed, Martin Mares, (Tue Apr 8, 4:35 pm)

Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:12 pm)

Re: [regression] e1000e broke e1000, Matthew Wilcox, (Tue Apr 8, 4:20 pm)

Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 4:39 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:35 pm)

Re: [regression] e1000e broke e1000, Martin Mares, (Tue Apr 8, 4:36 pm)

Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Matthew Wilcox, (Tue Apr 8, 3:32 pm)

Re: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e10..., Ingo Molnar, (Tue Apr 8, 3:51 pm)

Re: [regression] e1000e broke e1000, Bill Davidsen, (Wed Apr 9, 8:52 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 4:59 am)

Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 3:56 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:06 pm)

Re: [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:31 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Wed Apr 9, 3:12 pm)

Re: [regression] e1000e broke e1000, Jeff Garzik, (Wed Apr 9, 3:33 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 7:30 am)

Re: [regression] e1000e broke e1000, Chris Friesen, (Fri Apr 11, 11:40 am)

Re: [regression] e1000e broke e1000, Willy Tarreau, (Fri Apr 11, 3:29 pm)

Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:19 pm)

Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 4:33 pm)

Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 4:56 pm)

[patch] e1000=y && e1000e=m regression fix (was: Re:..., Ingo Molnar, (Wed Apr 9, 3:38 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Frans Pop, (Wed Apr 9, 4:49 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Krzysztof Halasa, (Wed Apr 9, 7:59 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Linus Torvalds, (Wed Apr 9, 9:40 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Krzysztof Halasa, (Thu Apr 10, 5:57 am)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Linus Torvalds, (Thu Apr 10, 10:30 am)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Krzysztof Halasa, (Thu Apr 10, 5:35 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Grant Grundler, (Thu Apr 10, 1:55 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Linus Torvalds, (Thu Apr 10, 3:27 pm)

Re: [patch] e1000=y && e1000e=m regression fix (was:..., Matthew Wilcox, (Thu Apr 10, 2:04 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Thu Apr 10, 2:26 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Chris Friesen, (Thu Apr 10, 5:20 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Wed Apr 9, 4:12 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Thu Apr 10, 2:29 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Thu Apr 10, 3:27 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Thu Apr 10, 5:23 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 7:26 am)

Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 7:36 am)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 8:16 am)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Fri Apr 11, 12:22 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Martin Mares, (Fri Apr 11, 1:10 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 12:45 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:34 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 6:06 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 7:00 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 7:43 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Sun Apr 13, 5:13 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Mon Jun 9, 3:24 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ondrej Zary, (Sun Apr 13, 5:34 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Christoph Hellwig, (Sat Apr 12, 9:07 am)

Re: [patch] e1000=y && e1000e=m regression fix, , (Fri Apr 11, 7:58 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:15 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 6:21 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 7:05 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 1:53 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 2:51 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Dan Noe, (Fri Apr 11, 5:01 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Krzysztof Halasa, (Fri Apr 11, 4:22 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:29 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:01 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:21 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Willy Tarreau, (Fri Apr 11, 3:25 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 3:38 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Fri Apr 11, 1:26 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Philip Craig, (Thu Apr 10, 8:46 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Randy Dunlap, (Thu Apr 10, 5:44 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Andi Kleen, (Fri Apr 11, 3:54 am)

Re: [patch] e1000=y && e1000e=m regression fix, Kok, Auke, (Thu Apr 10, 5:52 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Wed Apr 9, 4:53 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Jeff Garzik, (Wed Apr 9, 3:50 pm)

Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Wed Apr 9, 4:04 pm)

Re: [E1000-devel] [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 4:47 pm)

Navigation

Mail archive search

Popular discussions


linux-kernel:
Con Kolivas	Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler
debian developer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Steven Rostedt	Major regression on hackbench with SLUB
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:
Junio C Hamano	[0/4] What's not in 1.5.2 (overview)
Jan Hudec	Smart fetch via HTTP?
Peter Oberndorfer	Re: [StGIT PATCH] Don't use patches/<branch>/current
Nicolas Pitre	Re: git-index-pack really does suck..
openbsd-misc:
GVG GVG	ssh_exchange_identification: Connection closed by remote host
Reyk Floeter	Re: hoststated(8): DNS Relay uses unexpected source IP address
Mark Zimmerman	Re: Samba(SMB) or Netatalk(AFP)?
Anselm R. Garbe	OpenBSD 4.0 / Xorg -> vesa 1920x1200 widescreen resolution
linux-activists:
hh	Hardware compatibility list
Doug Evans	Re: Stabilizing Linux
Linus Benedict Torvalds	More answers
Dave `geek' Gymer	WARNING (was Re: New afio release)

Latest forum posts


what is "callback function"?.can anyone explain me please..	12 hours ago	Linux general
unable to remove block device driver module	22 hours ago	Linux kernel
Is there anything like Real-time drivers?	2 days ago	Linux general
I can't allocate more than 4 MB with pci_alloc_consistent	2 days ago	Linux kernel
Resetting the bios password for Toshiba Laptop	2 days ago	Hardware
Kernel panic while installing fedora core 5 or ubuntu	3 days ago	Hardware
Interactive Linux kernel map	3 days ago	Linux kernel
unable to add a variable in buffer_head struct	3 days ago	Linux kernel
Linux Input driver - setting scaling/resolution on USB mouse	3 days ago	Linux kernel
Merging Of Two File Systems	5 days ago	Linux kernel

Show all forums...

Colocation donated by:

Online users

Syndicate