Re: 2.6.25-rc8: FTP transfer errors

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ilpo Järvinen
Date: Thursday, April 10, 2008 - 1:46 pm

On Wed, 9 Apr 2008, Mark Lord wrote:


Sure, if you count in all whitespace/indentation/code moving changes to 
that as well... :-)


I might help if would add netdev on cc list in case you really want to 
reac net developers, otherwise they might just end up "ignoring it"... ;-)


Those touching fin/close are mostly whitespace/move things, so I doubt 
that you find these useful but in case you insist, here's the list:

056834d9f6f6eaf4cc7268569e53acab957aac27 [TCP]: cleanup tcp_{in,out}put.c style
058dc3342b71ffb3531c4f9df7c35f943f392b8d [TCP]: reduce tcp_output's indentation levels a bit
490d5046930276aae50dd16942649bfc626056f7 [TCP]: Uninline tcp_set_state

In addition, there's this one (...though I have read it number of times 
through and still cannot catch something that would cause the wrongness 
you're seeing):

e870a8efcddaaa3da7e180b6ae21239fb96aa2bb [TCP]: Perform setting of common 
control fields in one place

There's very little really on interesting side I can think of, mostly 
thinks are congestion control related changes... ...maybe either one of 
these could cause something unpleasant in some corner case:

bd515c3e48ececd774eb3128e81b669dbbd32637 [TCP]: Fix TSO deferring
0e3a4803aa06cd7bc2cfc1d04289df4f6027640a [TCP]: Force TSO splits to MSS boundaries

...e.g., if the latter causes a return with zero limit under some 
conditions, tso_fragment might generate, well, interesting packets and 
never finish if the condition persists but.


-- 
 i.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Bug #10391] 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Tue Apr 8, 4:02 pm)
2.6.25-rc8: FTP transfer errors, Mark Lord, (Tue Apr 8, 9:56 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 6:37 am)
Regression: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 7:06 am)
Re: 2.6.25-rc8: FTP transfer errors, Jeff Garzik, (Wed Apr 9, 9:46 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 10:16 am)
re: Regression: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 10:27 am)
Re: 2.6.25-rc8: FTP transfer errors, YOSHIFUJI Hideaki / , (Wed Apr 9, 10:30 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 12:05 pm)
Re: 2.6.25-rc8: FTP transfer errors, Jeff Garzik, (Wed Apr 9, 12:08 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Wed Apr 9, 3:29 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Wed Apr 9, 5:02 pm)
Re: 2.6.25-rc8: FTP transfer errors, Harvey Harrison, (Wed Apr 9, 5:37 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Wed Apr 9, 6:22 pm)
Re: 2.6.25-rc8: FTP transfer errors, Gerhard Mack, (Thu Apr 10, 6:52 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 8:07 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 8:15 am)
Re: 2.6.25-rc8: FTP transfer errors, Tilman Schmidt, (Thu Apr 10, 8:20 am)
Re: 2.6.25-rc8: FTP transfer errors, Gerhard Mack, (Thu Apr 10, 8:58 am)
Re: 2.6.25-rc8: FTP transfer errors, Ilpo Järvinen, (Thu Apr 10, 1:46 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 2:05 pm)
Re: 2.6.25-rc8: FTP transfer errors, Ilpo Järvinen, (Thu Apr 10, 2:43 pm)
Re: 2.6.25-rc8: FTP transfer errors, Jesper Juhl, (Thu Apr 10, 3:09 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 3:46 pm)
Re: 2.6.25-rc8: FTP transfer errors, Charlie Brady, (Thu Apr 10, 3:52 pm)
Re: 2.6.25-rc8: FTP transfer errors, Jesper Juhl, (Thu Apr 10, 4:02 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 4:05 pm)
Re: 2.6.25-rc8: FTP transfer errors, vincent-perrier, (Thu Apr 10, 4:10 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 4:14 pm)
Re: 2.6.25-rc8: FTP transfer errors, vincent-perrier, (Thu Apr 10, 4:32 pm)
Re: 2.6.25-rc8: FTP transfer errors, Jesper Juhl, (Thu Apr 10, 4:39 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 4:41 pm)
Re: 2.6.25-rc8: FTP transfer errors, vincent-perrier, (Thu Apr 10, 4:51 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 5:16 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 5:24 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 5:26 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 5:27 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 5:29 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 5:39 pm)
Re: 2.6.25-rc8: FTP transfer errors, Tilman Schmidt, (Thu Apr 10, 5:56 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Thu Apr 10, 6:08 pm)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Thu Apr 10, 6:23 pm)
Re: 2.6.25-rc8: FTP transfer errors, YOSHIFUJI Hideaki / , (Thu Apr 10, 7:59 pm)
Re: 2.6.25-rc8: FTP transfer errors, Ilpo Järvinen, (Thu Apr 10, 11:40 pm)
Re: 2.6.25-rc8: FTP transfer errors, Pavel Emelyanov, (Fri Apr 11, 12:50 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Fri Apr 11, 6:19 am)
Re: 2.6.25-rc8: FTP transfer errors, Evgeniy Polyakov, (Fri Apr 11, 7:35 am)
Re: 2.6.25-rc8: FTP transfer errors, Mark Lord, (Fri Apr 11, 7:59 am)
Re: 2.6.25-rc8: FTP transfer errors, Evgeniy Polyakov, (Fri Apr 11, 8:18 am)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Fri Apr 11, 11:07 am)
Re: 2.6.25-rc8: FTP transfer errors, Valdis.Kletnieks, (Fri Apr 11, 12:58 pm)
Re: 2.6.25-rc8: FTP transfer errors, Valdis.Kletnieks, (Fri Apr 11, 12:58 pm)
Re: 2.6.25-rc8: FTP transfer errors, Evgeniy Polyakov, (Fri Apr 11, 2:29 pm)
Re: 2.6.25-rc8: FTP transfer errors, Tilman Schmidt, (Fri Apr 11, 3:16 pm)
Re: 2.6.25-rc8: FTP transfer errors, Evgeniy Polyakov, (Fri Apr 11, 3:25 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Fri Apr 11, 3:26 pm)
Re: 2.6.25-rc8: FTP transfer errors, Tilman Schmidt, (Fri Apr 11, 3:27 pm)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Fri Apr 11, 3:27 pm)
Re: 2.6.25-rc8: FTP transfer errors, Tilman Schmidt, (Fri Apr 11, 4:23 pm)
Re: 2.6.25-rc8: FTP transfer errors, Evgeniy Polyakov, (Fri Apr 11, 10:37 pm)
Re: 2.6.25-rc8: FTP transfer errors, Ilpo Järvinen, (Sat Apr 12, 12:06 am)
Re: 2.6.25-rc8: FTP transfer errors, Willy Tarreau, (Sat Apr 12, 1:44 am)
Re: 2.6.25-rc8: FTP transfer errors, David Miller, (Sat Apr 12, 2:49 am)
Re: 2.6.25-rc8: FTP transfer errors, Rafael J. Wysocki, (Sun Apr 13, 11:15 am)
Reporting bugs and bisection (was: Re: 2.6.25-rc8: FTP tra ..., Rafael J. Wysocki, (Sun Apr 13, 11:40 am)
Re: 2.6.25-rc8: FTP transfer errors, Sergio Luis, (Sun Apr 13, 11:51 am)
Re: 2.6.25-rc8: FTP transfer errors, Rafael J. Wysocki, (Sun Apr 13, 12:24 pm)
Re: Reporting bugs and bisection (was: Re: 2.6.25-rc8: FTP ..., Rafael J. Wysocki, (Sun Apr 13, 12:27 pm)
Re: Reporting bugs and bisection, David Miller, (Sun Apr 13, 12:47 pm)
Re: Reporting bugs and bisection (was: Re: 2.6.25-rc8: FTP ..., Rafael J. Wysocki, (Sun Apr 13, 1:33 pm)
Re: Reporting bugs and bisection, David Miller, (Sun Apr 13, 1:35 pm)
Re: Reporting bugs and bisection, Stephen Clark, (Sun Apr 13, 3:24 pm)
Re: Reporting bugs and bisection, Rafael J. Wysocki, (Sun Apr 13, 3:41 pm)
Re: Reporting bugs and bisection, david, (Sun Apr 13, 4:51 pm)
Re: Reporting bugs and bisection, Jakub Narebski, (Sun Apr 13, 5:36 pm)
Re: Reporting bugs and bisection, Willy Tarreau, (Sun Apr 13, 9:39 pm)
Re: Reporting bugs and bisection, Al Viro, (Sun Apr 13, 10:39 pm)
Re: Reporting bugs and bisection, Andrew Morton, (Sun Apr 13, 11:24 pm)
Re: Reporting bugs and bisection, David Miller, (Sun Apr 13, 11:39 pm)
Re: Reporting bugs and bisection, David Miller, (Sun Apr 13, 11:43 pm)
Re: Reporting bugs and bisection, Al Viro, (Mon Apr 14, 12:23 am)
Re: Reporting bugs and bisection, Al Viro, (Mon Apr 14, 12:43 am)
Re: Reporting bugs and bisection, Andrew Morton, (Mon Apr 14, 1:04 am)
Re: Reporting bugs and bisection, David Miller, (Mon Apr 14, 1:30 am)
Re: Reporting bugs and bisection, Christoph Hellwig, (Mon Apr 14, 2:06 am)
Re: Reporting bugs and bisection, Andi Kleen, (Mon Apr 14, 2:26 am)
Re: Reporting bugs and bisection, Andi Kleen, (Mon Apr 14, 2:46 am)
Re: Reporting bugs and bisection, Andi Kleen, (Mon Apr 14, 2:58 am)
Re: Reporting bugs and bisection, Willy Tarreau, (Mon Apr 14, 3:00 am)
Re: Reporting bugs and bisection, Andrew Morton, (Mon Apr 14, 3:15 am)
Re: Reporting bugs and bisection, Andi Kleen, (Mon Apr 14, 3:16 am)
Re: Reporting bugs and bisection, Andi Kleen, (Mon Apr 14, 3:29 am)
Re: Reporting bugs and bisection, David Miller, (Mon Apr 14, 3:41 am)
Re: Reporting bugs and bisection, Adrian Bunk, (Mon Apr 14, 5:08 am)
Re: Reporting bugs and bisection, Arjan van de Ven, (Mon Apr 14, 7:43 am)
Re: Reporting bugs and bisection, James Morris, (Mon Apr 14, 8:54 am)
Re: Reporting bugs and bisection, Roman Shaposhnik, (Mon Apr 14, 10:35 am)
Re: Reporting bugs and bisection, Andrew Morton, (Mon Apr 14, 10:51 am)
Re: Reporting bugs and bisection, Arjan van de Ven, (Mon Apr 14, 11:24 am)
Re: Reporting bugs and bisection, Rene Herman, (Mon Apr 14, 12:13 pm)
Re: Reporting bugs and bisection, Ilpo Järvinen, (Mon Apr 14, 12:30 pm)
Re: Reporting bugs and bisection, Andrew Morton, (Mon Apr 14, 1:38 pm)
Re: Reporting bugs and bisection, David Miller, (Mon Apr 14, 3:01 pm)
Re: Reporting bugs and bisection, Rene Herman, (Mon Apr 14, 3:18 pm)
Re: Reporting bugs and bisection, Andrew Morton, (Mon Apr 14, 4:05 pm)
Re: Reporting bugs and bisection, Willy Tarreau, (Mon Apr 14, 9:55 pm)
Re: Reporting bugs and bisection, Bill Fink, (Mon Apr 14, 10:25 pm)
Re: Reporting bugs and bisection, David Newall, (Tue Apr 15, 2:33 am)
Re: Reporting bugs and bisection, Michael Kerrisk, (Tue Apr 15, 2:54 am)
Work WAS(Re: Reporting bugs and bisection, jamal, (Tue Apr 15, 6:18 am)
Re: Reporting bugs and bisection, David Newall, (Tue Apr 15, 7:04 am)
Re: Reporting bugs and bisection, Rafael J. Wysocki, (Tue Apr 15, 1:51 pm)
Re: about bisections, David Miller, (Tue Apr 15, 3:30 pm)
Re: about bisections, Ingo Molnar, (Tue Apr 15, 3:48 pm)
Re: Reporting bugs and bisection, David Newall, (Tue Apr 15, 7:34 pm)
Re: Reporting bugs and bisection, david, (Tue Apr 15, 8:53 pm)
Re: Reporting bugs and bisection, Willy Tarreau, (Tue Apr 15, 9:29 pm)
Re: Reporting bugs and bisection, David Newall, (Wed Apr 16, 2:06 am)
Re: Reporting bugs and bisection, Andi Kleen, (Wed Apr 16, 4:02 am)
Re: Reporting bugs and bisection, Rafael J. Wysocki, (Wed Apr 16, 5:13 am)
Re: Reporting bugs and bisection, Sverre Rabbelier, (Wed Apr 16, 5:15 am)
Re: Reporting bugs and bisection, Stephen Clark, (Wed Apr 16, 5:41 am)
Re: Reporting bugs and bisection, Adrian Bunk, (Wed Apr 16, 6:26 am)
Re: Reporting bugs and bisection, Andrew Morton, (Wed Apr 16, 12:02 pm)
Re: Reporting bugs and bisection, Sverre Rabbelier, (Wed Apr 16, 12:39 pm)
Re: Reporting bugs and bisection, Sverre Rabbelier, (Wed Apr 16, 12:43 pm)
Re: Reporting bugs and bisection, Adrian Bunk, (Wed Apr 16, 12:55 pm)
Re: Reporting bugs and bisection, Alexey Dobriyan, (Wed Apr 16, 12:58 pm)
Re: Reporting bugs and bisection, Arjan van de Ven, (Wed Apr 16, 1:01 pm)
Re: Reporting bugs and bisection, Willy Tarreau, (Wed Apr 16, 1:04 pm)
Re: Reporting bugs and bisection, Adrian Bunk, (Wed Apr 16, 1:16 pm)
Re: Reporting bugs and bisection, Adrian Bunk, (Wed Apr 16, 1:53 pm)
Re: Reporting bugs and bisection, Sverre Rabbelier, (Wed Apr 16, 2:05 pm)
Re: Reporting bugs and bisection, Jesper Juhl, (Wed Apr 16, 2:17 pm)
Re: Reporting bugs and bisection, Adrian Bunk, (Wed Apr 16, 2:25 pm)
Re: Reporting bugs and bisection, J. Bruce Fields, (Thu Apr 17, 6:50 am)
Re: Reporting bugs and bisection, Adrian Bunk, (Thu Apr 17, 8:26 am)
Re: Reporting bugs and bisection, David Newall, (Thu Apr 17, 10:04 am)
Re: Reporting bugs and bisection, Rafael J. Wysocki, (Thu Apr 17, 12:09 pm)
Re: Reporting bugs and bisection, Ray Lee, (Thu Apr 17, 12:35 pm)
Re: Reporting bugs and bisection, Sverre Rabbelier, (Thu Apr 17, 12:57 pm)
Re: Reporting bugs and bisection, Al Viro, (Thu Apr 17, 1:16 pm)
Re: Reporting bugs and bisection, Ray Lee, (Thu Apr 17, 1:38 pm)
Re: Reporting bugs and bisection, Al Viro, (Thu Apr 17, 1:53 pm)
Re: Reporting bugs and bisection, Ray Lee, (Thu Apr 17, 2:01 pm)