Home » Mailing list archives » linux-kernel » 2008 » April » 10

Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cacheinfo v3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Jackson <pj@...>
To: Mike Travis <travis@...>
Cc: <bert.wesarg@...>, <mingo@...>, <tglx@...>, <hpa@...>, <akpm@...>, <linux-kernel@...>
Subject: Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cacheinfo v3
Date: Thursday, April 10, 2008 - 10:03 am

Mike, in response to a suggestion from Bert, wrote:

I should have read ahead to this discussion, before responding
a minute ago with my suggestion using:

  typedef enum { print_as_mask, print_as_list } map_printer_t;

I slightly dislike the subversion of the cpumask interface,
and slightly -do- like the 7 instructions saved.

Either of these variants (my typedef or Berts function pointer)
would be fine by me, as you prefer, Mike.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/3] x86: modify show_shared_cpu_map in intel_cachein..., Mike Travis, (Tue Apr 8, 2:43 pm)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Paul Jackson, (Thu Apr 10, 9:57 am)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Bert Wesarg, (Tue Apr 8, 3:36 pm)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Mike Travis, (Tue Apr 8, 4:44 pm)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Bert Wesarg, (Thu Apr 10, 1:24 pm)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Paul Jackson, (Thu Apr 10, 1:36 pm)
Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cac..., Paul Jackson, (Thu Apr 10, 10:03 am)