Home » Mailing list archives » linux-kernel » 2008 » April » 1

[patch 1/15] Makefiles and Kconfig

Previous thread: [patch 0/15] LogFS take five by joern on Tuesday, April 1, 2008 - 2:13 pm. (7 messages)

Next thread: [patch 2/15] fs/logfs/logfs_abi.h by joern on Tuesday, April 1, 2008 - 2:13 pm. (3 messages)
[view original message]
From: <joern@...>
To: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: [patch 1/15] Makefiles and Kconfig
Date: Tuesday, April 1, 2008 - 2:13 pm

--- linux-2.6.24logfs/fs/Kconfig~logfs	2008-03-24 12:39:10.190939342 +0100

+++ linux-2.6.24logfs/fs/Kconfig	2008-04-01 19:48:18.517351063 +0200

@@ -1385,6 +1385,23 @@ config JFFS2_CMODE_FAVOURLZO


 endchoice


+config LOGFS

+	bool "Log Filesystem (EXPERIMENTAL)"

+	depends on (MTD || BLOCK) && EXPERIMENTAL

+	select ZLIB_INFLATE

+	select ZLIB_DEFLATE

+	select CRC32

+	help

+	  Flash filesystem aimed to scale efficiently to large devices.

+	  In comparison to JFFS2 it offers significantly faster mount

+	  times and potentially less RAM usage, although the latter has

+	  not been measured yet.

+

+	  In its current state it is still very experimental and should

+	  not be used for other than testing purposes.

+

+	  If unsure, say N.

+

 config CRAMFS

 	tristate "Compressed ROM file system support (cramfs)"

 	depends on BLOCK

--- linux-2.6.24logfs/fs/Makefile~logfs	2008-03-24 12:39:10.190939342 +0100

+++ linux-2.6.24logfs/fs/Makefile	2008-03-24 12:40:08.127616634 +0100

@@ -99,6 +99,7 @@ obj-$(CONFIG_NTFS_FS)		+= ntfs/

 obj-$(CONFIG_UFS_FS)		+= ufs/

 obj-$(CONFIG_EFS_FS)		+= efs/

 obj-$(CONFIG_JFFS2_FS)		+= jffs2/

+obj-$(CONFIG_LOGFS)		+= logfs/

 obj-$(CONFIG_AFFS_FS)		+= affs/

 obj-$(CONFIG_ROMFS_FS)		+= romfs/

 obj-$(CONFIG_QNX4FS_FS)		+= qnx4/

--- /dev/null	2008-03-30 12:15:48.586669308 +0200

+++ linux-2.6.24logfs/fs/logfs/Makefile	2008-04-01 19:48:07.170961891 +0200

@@ -0,0 +1,14 @@

+obj-$(CONFIG_LOGFS)	+= logfs.o

+

+logfs-y	+= compr.o

+logfs-y	+= dir.o

+logfs-y	+= file.o

+logfs-y	+= gc.o

+logfs-y	+= inode.o

+logfs-y	+= journal.o

+logfs-y	+= memtree.o

+logfs-y	+= readwrite.o

+logfs-y	+= segment.o

+logfs-y	+= super.o

+logfs-$(CONFIG_BLOCK)	+= dev_bdev.o

+logfs-$(CONFIG_MTD)	+= dev_mtd.o


--
[view original message]
From: Arnd Bergmann <arnd@...>
To: <joern@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Monday, April 7, 2008 - 8:30 pm

Is it really still the "Log Filesystem"? By now, I had the impression

that "logfs" is a name by itself, so it should be called the

"Logfs file system", and "config LOGFS_FS" respectively, like


You shouldn't add the Makefile and Kconfig before adding the actual

files, or you could cause git-bisect problems.


	Arnd <><

--
[view original message]
From: Jörn <joern@...>
To: Arnd Bergmann <arnd@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Tuesday, April 8, 2008 - 4:33 am

"Logfs file system" might make sense.  LOGFS_FS is something I would

rather avoid.  For some reason my brain reacts strongly to repetition,


I keep hearing that and I also continue to forget it.  It shouldn't

matter either way, because it simply makes no sense to merge 15 seperate

patches file-by-file for something that is functionally one change.  The

split is all about review and has nothing to do with merging.


But if I finally remembered it, at least these comments would cease.

I'll try.


Jörn


--

Beware of bugs in the above code; I have only proved it correct, but

not tried it.

-- Donald Knuth

--
[view original message]
From: Arnd Bergmann <arnd@...>
To: Jörn Engel <joern@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Tuesday, April 8, 2008 - 9:41 am

How about LOG_FS then? I don't think there is a really good argument

either way, but a large majority uses the *_FS notation in Kconfig.


	Arnd <><

--
[view original message]
From: Jörn <joern@...>
To: Arnd Bergmann <arnd@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Tuesday, April 8, 2008 - 9:52 am

Fair enough.


Jörn


--

Write programs that do one thing and do it well. Write programs to work

together. Write programs to handle text streams, because that is a

universal interface.

-- Doug MacIlroy

--
[view original message]
From: Christian Borntraeger <borntraeger@...>
To: <joern@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Monday, April 7, 2008 - 4:28 am

[...] 


Hi Joern,


can you make the Kconfig/Makefile changes the last patch? This will help git

bisect. 


Christian

--
[view original message]
From: Jörn <joern@...>
To: Christian Borntraeger <borntraeger@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <linux-mtd@...>
Subject: Re: [patch 1/15] Makefiles and Kconfig
Date: Monday, April 7, 2008 - 4:40 am

I won't merge 15 patches anyway.  The splitup is for review purposes

only. ;)


Jörn


--

Sometimes, asking the right question is already the answer.

-- Unknown

--
Previous thread: [patch 0/15] LogFS take five by joern on Tuesday, April 1, 2008 - 2:13 pm. (7 messages)

Next thread: [patch 2/15] fs/logfs/logfs_abi.h by joern on Tuesday, April 1, 2008 - 2:13 pm. (3 messages)