Home » Mailing list archives » linux-kernel » 2008 » April » 1

Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo

Previous thread: Re: [mmotm] PM build error (PM_SLEEP undef) by Rafael J. Wysocki on Wednesday, March 19, 2008 - 6:16 pm. (3 messages)

Next thread: Come join me on ssbbw4u... by P Alb on Wednesday, March 19, 2008 - 9:28 pm. (1 message)
[view original message]
From: Tino Keitel <tino.keitel@...>
To: <linux-kernel@...>
Subject: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Thursday, March 20, 2008 - 2:05 am

Hi folks,


whereas I had working suspend with 2.6.25-rc5, I had a hang at resume

with git HEAD from March 19th (something after 2.6.25-rc6). I tried it

again and got another hang, so it seems to be reproducible.


Any hints what commit might have broke suspend? I won't have the time

to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC

until next Tuesday.


This is a Mac mini Core Duo. Here is the lspci -nn output:


00:00.0 Host bridge [0600]: Intel Corporation Mobile 945GM/PM/GMS,

943/940GML and 945GT Express Memory Controller Hub [8086:27a0] (rev 03)


00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile

945GM/GMS, 943/940GML Express Integrated Graphics Controller

[8086:27a2] (rev 03)


00:07.0 Performance counters [1101]: Intel Corporation Unknown device

[8086:27a3] (rev 03)


00:1b.0 Audio device [0403]: Intel Corporation 82801G (ICH7 Family)

High Definition Audio Controller [8086:27d8] (rev 02)


00:1c.0 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI

Express Port 1 [8086:27d0] (rev 02)


00:1c.1 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI

Express Port 2 [8086:27d2] (rev 02)


00:1d.0 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family)

USB UHCI Controller #1 [8086:27c8] (rev 02)


00:1d.1 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family)

USB UHCI Controller #2 [8086:27c9] (rev 02)


00:1d.2 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family)

USB UHCI Controller #3 [8086:27ca] (rev 02)


00:1d.3 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family)

USB UHCI Controller #4 [8086:27cb] (rev 02)


00:1d.7 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family)

USB2 EHCI Controller [8086:27cc] (rev 02)


00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge

[8086:2448] (rev e2)


00:1f.0 ISA bridge [0601]: Intel Corporation 82801GBM (ICH7-M) LPC

Interface Bridge [8086:27b9] (rev 02)


00:1f.1 IDE interface [0101]: Intel Corporation 82801G (ICH7 Family)

I...
[ message continues ]
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Tino Keitel <tino.keitel@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Thursday, March 20, 2008 - 6:10 am

No ideas for now.


I have created a Bugzilla entry for this problem at:

http://bugzilla.kernel.org/show_bug.cgi?id=10291


Thanks,

Rafael

--
[view original message]
From: Andrew Morton <akpm@...>
To: Tino Keitel <tino.keitel@...>
Cc: <linux-kernel@...>, Rafael J. Wysocki <rjw@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Thursday, March 20, 2008 - 6:25 am

Please try Linus's current tree - quite a few things got reverted today

which might have fixed this.

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, Rafael J. Wysocki <rjw@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Thursday, March 20, 2008 - 6:54 am

OK, I'll try it.


Regards,

Tino

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Andrew Morton <akpm@...>, <linux-kernel@...>, Rafael J. Wysocki <rjw@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, March 25, 2008 - 7:13 pm

I tried HEAD from yesterday, but resume still fails. So it looks like I

need to start a git bisect.


Regards,

Tino

--
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Tino Keitel <tino.keitel@...>
Cc: Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Friday, March 28, 2008 - 7:03 pm

Can you please try to boot with acpi_new_pts_ordering and retest?


Thanks,

Rafael

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Rafael J. Wysocki <rjw@...>
Cc: Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Monday, March 31, 2008 - 5:28 pm

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:


I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a),

without success. I still got the same hand at resume.


Regards,

Tino


--
[view original message]
From: Pavel Machek <pavel@...>
To: Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Monday, March 31, 2008 - 5:50 pm

You should put "acpi_new_pts_ordering" on kernel command line.

									Pavel

--

(english) http://www.livejournal.com/~pavelmachek

(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Pavel Machek <pavel@...>
Cc: Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Monday, March 31, 2008 - 6:01 pm

I did, just forgot to mention it.


Regards,

Tino

--
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Monday, March 31, 2008 - 6:17 pm

OK, thanks.


Have you tried to do:


# echo core > /sys/power/pm_test

# echo mem > /sys/power/state


(it's good to boot the kernel with no_console_suspend and do

"echo 8 > /proc/sys/kernel/printk" before that to see the messages)?


Rafael

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Rafael J. Wysocki <rjw@...>
Cc: Pavel Machek <pavel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 4:04 am

Thanks, I'll try this evening. What should I look for in the kernel

messages?


Regards,

Tino

--
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 5:03 pm

Any irregularities.  Please just post the dmesg output if the system survives.


If there are any oopes etc., you should see them. :-)


Thanks,

Rafael

--
[view original message]
From: Soeren Sonnenburg <sonne@...>
To: Tino Keitel <tino.keitel@...>
Cc: Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 2:23 am

I am having the hang on resume problem too (macbook pro), cf.

http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.


Soeren

--

For the one fact about the future of which we can be certain is that it

will be utterly fantastic. -- Arthur C. Clarke, 1962

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Soeren Sonnenburg <sonne@...>
Cc: Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 2:27 am

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.


Regards,

Tino

--
[view original message]
From: Pavel Machek <pavel@...>
To: Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 6:52 am

Any chance to bisect?


--

(english) http://www.livejournal.com/~pavelmachek

(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Pavel Machek <pavel@...>, <linux-usb@...>
Cc: Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 2:37 pm

git-bisect revealed this:


$ git bisect good

e82cc1288fa57857c6af8c57f3d07096d4bcd9d9 is first bad commit

commit e82cc1288fa57857c6af8c57f3d07096d4bcd9d9

Author: David Brownell <david-b@pacbell.net>

Date:   Fri Mar 7 13:49:42 2008 -0800


    USB: fix ehci unlink regressions


    The recent EHCI driver update to split the IAA watchdog timer out from

    the other timers made several things work better, but not everything;

    and it created a couple new issues in bugzilla.  Ergo this patch:


      - Handle a should-be-rare SMP race between the watchdog firing

        and (very late) IAA interrupts;


      - Remove a shouldn't-have-been-added WARN_ON() test;


      - Guard against one observed OOPS;


      - If this watchdog fires during clean HC shutdown, it should act

        as a NOP instead of interfering with the shutdown sequence;


      - Guard against silicon errata hypothesized by some vendors:

          * IAA status latch broken, but IAAD cleared OK;

          * IAAD wasn't cleared when IAA status got reported;


    The WARN_ON is in bugzilla as 10168; the OOPS as 10078; these are

    both regressions.


    Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

    Tested-by: Gordon Farquharson <gordonfarquharson@gmail.com>

251bc90076ea0b3a14d0b88dd250581fa815b5de M	drivers


For the linux-usb people: this commit breaks resume from suspend to RAM

on my Mac mini Core Duo. It worked with 2.6.24, 2.6.25-rc5, and was

broken since 2.6.25-rc6 (also with -rc7 and later). See

http://lkml.org/lkml/2008/3/20/23 for more information.


Regards,

Tino

--
[view original message]
From: David Brownell <david-b@...>
To: <tino.keitel@...>, <pavel@...>, <linux-usb@...>
Cc: <sonne@...>, <rjw@...>, <linux-kernel@...>, <lenb@...>, <akpm@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 4:06 pm

Most curious.  Based on what I read earlier, I was wondering about

the handling of the unlink watchdog during a known-dodgey path.


This "fires during a clean shutdown" path.  If there's any way this

patch would affect resume handling, that's where I'd expect it to

kick in.  Virtually nothing else *could* cause problems there.


If you'd like to experiment, modify the "if (...)" at the top of the

ehci_iaa_watchdog() function and make it just check to see if there's


FWIW the former has been confirmed as existing on some current AMD/ATI


--
[view original message]
From: Alan Stern <stern@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 3:06 pm

Can you get any information out of the computer after the hang?  It

would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an

Alt-SysRq-T stack dump.


Alan Stern


--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Alan Stern <stern@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 4:25 pm

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:


Looks difficult. The text console stays black after resume, and there

is no serial interface.


Regards,

Tino

--
[view original message]
From: Alan Stern <stern@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 5:02 pm

Network console?  SSH?  Or even telnet?


Alan Stern


--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Alan Stern <stern@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 5:06 pm

Network is dead, too.


Regards,

Tino

--
[view original message]
From: Alan Stern <stern@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 3:26 pm

Tino, try this patch.  It fixed Mark Lord's problem, which looked the

same as yours.


Alan Stern


--- rc8/drivers/usb/host/ehci-hub.c	2008-03-11 11:18:40.000000000 -0400

+++ linux/drivers/usb/host/ehci-hub.c	2008-04-02 13:28:50.000000000 -0400

@@ -135,8 +135,6 @@

 		hcd->state = HC_STATE_QUIESCING;

 	}

 	ehci->command = ehci_readl(ehci, &ehci->regs->command);

-	if (ehci->reclaim)

-		end_unlink_async(ehci);

 	ehci_work(ehci);


 	/* Unlike other USB host controller types, EHCI doesn't have

@@ -180,6 +178,9 @@

 	ehci_halt (ehci);

 	hcd->state = HC_STATE_SUSPENDED;


+	if (ehci->reclaim)

+		end_unlink_async(ehci);

+

 	/* allow remote wakeup */

 	mask = INTR_MASK;

 	if (!device_may_wakeup(&hcd->self.root_hub->dev))


--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Alan Stern <stern@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 3:47 pm

Fine, it seems to solve the hang, I see no problems after the resume.

Thanks a lot.


Regards,

Tino

--
[view original message]
From: Soeren Sonnenburg <kernel@...>
To: Tino Keitel <tino.keitel@...>
Cc: Alan Stern <stern@...>, Pavel Machek <pavel@...>, <linux-usb@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 4:37 pm

Using this patch fixes the hang for my macbookpro1,1 too. However the

console stays black after resume, though I can s2ram multiple times and

reboot...


Soeren

--
[view original message]
From: Alan Stern <stern@...>
To: Tino Keitel <tino.keitel@...>
Cc: Pavel Machek <pavel@...>, <linux-usb@...>, Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 10:25 am

Okay, then try this.  Boot with "no_console_suspend" on the command

line.  Do "echo devices >/sys/power/pm_test" before starting the

suspend.  Then "echo mem >/sys/power/state", and while the system is

paused try unplugging/replugging a USB device.


Maybe that will provide usable information.


Alan Stern


--
[view original message]
From: Tino Keitel <tino.keitel@...>
To: Pavel Machek <pavel@...>
Cc: Soeren Sonnenburg <sonne@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 8:55 am

I'll try to find the time for a bisect his week.


Regards,

Tino

--
[view original message]
From: Soeren Sonnenburg <kernel@...>
To: Tino Keitel <tino.keitel@...>
Cc: Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 2:38 am

No never worked in 2.6.25 (at least from rc2 on) and still does not in

rc7-current-git. But note that on console I could suspend to ram and

resume but the display is not anymore coming back with s2ram - from

within X it freezes though.


Soeren


--
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Soeren Sonnenburg <kernel@...>
Cc: Tino Keitel <tino.keitel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Tuesday, April 1, 2008 - 5:05 pm

Please try -rc8.


Thanks,

Rafael

--
[view original message]
From: Soeren Sonnenburg <kernel@...>
To: Rafael J. Wysocki <rjw@...>
Cc: Tino Keitel <tino.keitel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 1:33 pm

OK I did. Now not only the console stays black but blindly typing

reboot/s2ram does not do anything after a resume... in this respect rc7

was better though not usable (as the display remained off).


Soeren

--
[view original message]
From: Rafael J. Wysocki <rjw@...>
To: Soeren Sonnenburg <kernel@...>
Cc: Tino Keitel <tino.keitel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>, Felix <felix@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 1:56 pm

The Felix's MacBook suspends sucessfully with current -git, AFAICS.  Perhaps

you can compare .configs?


Rafael

--
[view original message]
From: Soeren Sonnenburg <kernel@...>
To: Rafael J. Wysocki <rjw@...>
Cc: Tino Keitel <tino.keitel@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Len Brown <lenb@...>, Pavel Machek <pavel@...>, Felix <felix@...>
Subject: Re: 2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo
Date: Wednesday, April 2, 2008 - 2:42 pm

Well it suspends, since rc2/3 or so but it simply does not resume as it

used to in 2.24. Anyway config is here

http://nn7.de/debugging/config.gz .

Also note that this is a macbookpro1,1 and that I have to use

http://marc.info/?l=linux-kernel&m=120674502201007&w=4 to be able to

boot.


Soeren

--
Previous thread: Re: [mmotm] PM build error (PM_SLEEP undef) by Rafael J. Wysocki on Wednesday, March 19, 2008 - 6:16 pm. (3 messages)

Next thread: Come join me on ssbbw4u... by P Alb on Wednesday, March 19, 2008 - 9:28 pm. (1 message)