login
Header Space

 
 

Re: [RFC][-mm] Add an owner to the mm_struct (v3)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Balbir Singh <balbir@...>
Cc: Pavel Emelianov <xemul@...>, Hugh Dickins <hugh@...>, Sudhir Kumar <skumar@...>, YAMAMOTO Takashi <yamamoto@...>, <lizf@...>, <linux-kernel@...>, <taka@...>, <linux-mm@...>, David Rientjes <rientjes@...>, Andrew Morton <akpm@...>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>
Date: Tuesday, April 1, 2008 - 2:16 am

On Mon, Mar 31, 2008 at 10:43 PM, Balbir Singh
<balbir@linux.vnet.ibm.com> wrote:

This should probably be inlined in the header file if it's needed
outside this file.

I think this is stale.


I think (as you mentioned earlier) that we need an RCU critical
section in this function, in order for the tasklist traversal to be
safe.

Maybe also BUG_ON(p != mm->owner) ?


Since mm != NULL, no need to test for c->mm since if it's NULL then c->mm != mm


Here we'll want to call vm_cgroup_update_mm_owner(), to adjust the
accounting. (Or if in future we end up with more than a couple of
subsystems that want notification at this time, we'll want to call
cgroup_update_mm_owner() and have it call any interested subsystems.

Paul
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][-mm] Add an owner to the mm_struct (v3), Balbir Singh, (Tue Apr 1, 1:43 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Paul Menage, (Tue Apr 1, 2:16 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Balbir Singh, (Tue Apr 1, 2:23 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Paul Menage, (Tue Apr 1, 2:48 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Balbir Singh, (Tue Apr 1, 3:26 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Balbir Singh, (Tue Apr 1, 4:13 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), YAMAMOTO Takashi, (Tue Apr 1, 2:03 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Balbir Singh, (Tue Apr 1, 2:25 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), Paul Menage, (Tue Apr 1, 2:06 am)
Re: [RFC][-mm] Add an owner to the mm_struct (v3), YAMAMOTO Takashi, (Tue Apr 1, 2:24 am)
speck-geostationary