login
Header Space

 
 

jbd/2: eliminate code duplication and gracefully handle cache initialisation failure

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ext4@...>
Cc: <linux-kernel@...>, Christoph Hellwig <hch@...>, Theodore Tso <tytso@...>, <sct@...>, <akpm@...>, <adilger@...>, Duane Griffin <duaneg@...>
Date: Saturday, March 8, 2008 - 2:37 pm

fs/jbd/journal.c  |  149 +++++++++++++++++++++++-------------------------
 fs/jbd/revoke.c   |  164 +++++++++++++++++++++++------------------------------
 fs/jbd2/journal.c |  154 ++++++++++++++++++++++++-------------------------
 fs/jbd2/revoke.c  |  164 +++++++++++++++++++++++------------------------------
 4 files changed, 291 insertions(+), 340 deletions(-)

This is version 2 of the jdb/2 patches to eliminate code duplication and
gracefully handle cace initialisation failure.

Changes since V1:
 * Check whether caches are initialised in journal_init_common. If not then
   attempt to initialise them once before failing.
 * Addressed all Andreas Dilger's comments.
 * Modified the initialisation/destruction methods to match Christoph Hellwig's
   suggestions.
 * Rolled the if/assertion and debugfs changes into the main patch.

Andrew, please drop the earlier versions of these patches and replace them with
these ones, thanks.

Cheers,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
jbd/2: eliminate code duplication and gracefully handle cach..., Duane Griffin, (Sat Mar 8, 2:37 pm)
speck-geostationary