Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-arm-kernel@...>
Cc: Liam Girdwood <lg@...>, Andrew Morton <akpm@...>, linux-kernel <linux-kernel@...>
Date: Friday, March 7, 2008 - 9:13 pm

On Thursday 06 March 2008, Liam Girdwood wrote:


Versus Documentation/hwmon/sysfs-interface which uses
millivolts and milliamperes respectively.

Why not adopt the same convention?  (This applies to
many attributes, not just these two.)


Also, I'm kind of curious what you've thought about
power budgeting.  Example, a power supply ("regulator")
may be able to supply a voltage within a given range,
but only up to a maximum of 200 mA worth.

The model visible through these sysfs attributes seems to
be an either/or thing ... either regulating voltage, or
current, but not addressing the corresponding constraints
on the other one.



How about just "undefined" for all those min/max values?



Ditto re "milli" vs "micro".  Also, "requested" seems a bit opaque.
As a sum, maybe "total_mi{lli,cro}amps" would be more explanatory.

- Dave

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[UPDATED v3][PATCH 5/7] regulator: sysfs ABI, Liam Girdwood, (Thu Mar 6, 2:12 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, David Brownell, (Fri Mar 7, 9:13 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, Liam Girdwood, (Sat Mar 8, 5:13 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, Greg KH, (Fri Mar 7, 12:12 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, Mark Brown, (Fri Mar 7, 5:17 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, David Brownell, (Fri Mar 7, 9:17 pm)
Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI, Liam Girdwood, (Sat Mar 8, 1:26 pm)