login
Header Space

 
 

Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Duane Griffin <duaneg@...>
Cc: <linux-ext4@...>, <linux-kernel@...>, Theodore Tso <tytso@...>, <sct@...>, <akpm@...>
Date: Friday, March 7, 2008 - 5:23 pm

On Mar 07, 2008  01:31 +0000, Duane Griffin wrote:

It would probably be prudent to verify that these caches are initialized
at journal_load() time and either re-try to create the cache, and/or report
an error in that case and refuse to continue mounting.

Also, I note that journal_init_journal_head_cache() is comparing pointers
to "0", a style no-no...


Acked-by: Andreas Dilger <adilger@sun.com>

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/3] jbd2: replace potentially false assertion wi..., Andreas Dilger, (Fri Mar 7, 5:23 pm)
Re: [PATCH 2/3] jbd2: replace potentially false assertion wi..., Christoph Hellwig, (Sat Mar 8, 11:02 am)
Re: [PATCH 2/3] jbd2: replace potentially false assertion wi..., Christoph Hellwig, (Sat Mar 8, 12:42 pm)
speck-geostationary