login
Header Space

 
 

[patch] drivers/char/esp.c: fix bootup lockup (was: Re: Linux 2.6.25-rc4)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alan Cox <alan@...>, Jiri Slaby <jirislaby@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Rafael J. Wysocki <rjw@...>, Linus Torvalds <torvalds@...>
Date: Friday, March 7, 2008 - 6:08 am

randconfig testing found a bootup lockup in drivers/char/esp.c - find 
the fix below. Not sure why it became more prominent in 2.6.25-rc4, the 
bug seems rather old and i've been doing allyesconfig bootups for ages 
with CONFIG_ESP enabled.

------------->
Subject: drivers/char/esp.c: fix bootup lockup
From: Ingo Molnar <mingo@elte.hu>
Date: Fri Mar 07 10:47:43 CET 2008

fix this bootup lockup:

 PM: Adding info for No Bus:ttyP63
 ttyP32 at 0x0240 (irq = 0) is an ESP primary port
 BUG: spinlock lockup on CPU#0, swapper/1, f56dd004
 Pid: 1, comm: swapper Not tainted 2.6.25-rc4-sched-devel.git-x86-latest.git #402 [<c03ac6f4>] _raw_spin_lock+0x134/0x140
  [<c08649be>] _spin_lock_irqsave+0x5e/0x80
  [<c0b9fbfe>] ? espserial_init+0x2be/0x6e0
  [<c0b9fbfe>] espserial_init+0x2be/0x6e0
  [<c0b877a3>] kernel_init+0x83/0x260
  [<c0b9f940>] ? espserial_init+0x0/0x6e0
  [<c010416a>] ? restore_nocheck_notrace+0x0/0xe
  [<c0b87720>] ? kernel_init+0x0/0x260
  [<c0b87720>] ? kernel_init+0x0/0x260
  [<c0104507>] kernel_thread_helper+0x7/0x10
  =======================

kzalloc() is not the way to initialize spinlocks anymore.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/char/esp.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/char/esp.c
===================================================================
--- linux.orig/drivers/char/esp.c
+++ linux/drivers/char/esp.c
@@ -2484,6 +2484,7 @@ static int __init espserial_init(void)
 			return 0;
 		}
 
+		spin_lock_init(&info->lock);
 		/* rx_trigger, tx_trigger are needed by autoconfig */
 		info->config.rx_trigger = rx_trigger;
 		info->config.tx_trigger = tx_trigger;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.25-rc4, Linus Torvalds, (Wed Mar 5, 1:03 am)
[patch] drivers/char/esp.c: fix bootup lockup (was: Re: Linu..., Ingo Molnar, (Fri Mar 7, 6:08 am)
Re: [patch] drivers/char/esp.c: fix bootup lockup, Jiri Slaby, (Sun Mar 9, 9:41 am)
Re: [patch] drivers/char/esp.c: fix bootup lockup, Rafael J. Wysocki, (Sun Mar 9, 6:49 pm)
Re: [patch] drivers/char/esp.c: fix bootup lockup, Jiri Slaby, (Sun Mar 9, 7:04 pm)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Thu Mar 6, 5:00 am)
Re: Linux 2.6.25-rc4, Jens Axboe, (Thu Mar 6, 8:59 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Thu Mar 6, 9:38 am)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Thu Mar 6, 9:33 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Thu Mar 6, 10:06 am)
Re: Linux 2.6.25-rc4, Jens Axboe, (Thu Mar 6, 9:55 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Thu Mar 6, 5:17 pm)
Re: Linux 2.6.25-rc4, Jens Axboe, (Fri Mar 7, 4:48 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Fri Mar 7, 6:04 pm)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Sat Mar 8, 4:22 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sat Mar 8, 5:05 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Mon Mar 10, 4:55 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Mon Mar 10, 8:36 am)
Re: Linux 2.6.25-rc4, Rafael J. Wysocki, (Mon Mar 10, 9:10 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Mon Mar 10, 10:04 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 10:01 am)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Sun Mar 16, 12:56 pm)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Sun Mar 16, 1:13 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 2:18 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 2:07 pm)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Sun Mar 16, 2:13 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 3:54 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 6:59 pm)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Sun Mar 16, 7:27 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Mon Mar 17, 5:09 pm)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Mon Mar 17, 6:52 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Mon Mar 17, 8:18 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Tue Mar 18, 9:03 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Tue Mar 18, 9:32 am)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Tue Mar 18, 11:41 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Tue Mar 18, 9:21 pm)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Tue Mar 18, 9:28 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Tue Mar 18, 11:24 pm)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Tue Mar 18, 11:28 pm)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Tue Mar 18, 11:56 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Wed Mar 19, 12:03 am)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Wed Mar 19, 12:48 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Wed Mar 19, 7:14 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Tue Mar 18, 12:30 pm)
Re: Linux 2.6.25-rc4 , Linus Torvalds, (Tue Mar 18, 12:47 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Tue Mar 18, 5:02 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Tue Mar 18, 10:48 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Tue Mar 18, 11:10 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 2:36 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 3:08 pm)
Re: Linux 2.6.25-rc4, Alan Cox, (Sun Mar 16, 2:56 pm)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Sun Mar 16, 3:39 pm)
Re: Linux 2.6.25-rc4, Alan Cox, (Sun Mar 16, 4:31 pm)
Re: Linux 2.6.25-rc4, Mark Lord, (Fri Mar 21, 11:03 am)
Re: Linux 2.6.25-rc4, Alan Cox, (Fri Mar 21, 10:49 am)
Re: Linux 2.6.25-rc4, Linus Torvalds, (Sun Mar 16, 5:06 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 2:26 pm)
Re: Linux 2.6.25-rc4, Jens Axboe, (Mon Mar 17, 3:23 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 2:25 pm)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 2:23 pm)
Re: Linux 2.6.25-rc4, Alan Cox, (Sun Mar 16, 2:44 pm)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 10:29 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Sun Mar 16, 10:29 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Sun Mar 16, 11:14 am)
Re: Linux 2.6.25-rc4 , Anders Eriksson, (Mon Mar 10, 9:19 am)
Re: Linux 2.6.25-rc4, Bartlomiej Zolnierkiewicz..., (Mon Mar 10, 9:56 am)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Thu Mar 6, 9:06 am)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Fri Mar 7, 4:53 am)
Re: Linux 2.6.25-rc4, Pavel Machek, (Sat Mar 8, 7:36 pm)
Re: Linux 2.6.25-rc4, Andi Kleen, (Sun Mar 9, 8:55 am)
Re: Linux 2.6.25-rc4, Pavel Machek, (Mon Mar 10, 6:10 am)
Re: Linux 2.6.25-rc4, Andi Kleen, (Mon Mar 10, 7:52 am)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Sun Mar 9, 7:59 am)
Re: Linux 2.6.25-rc4, Jens Axboe, (Fri Mar 7, 4:57 am)
Re: Linux 2.6.25-rc4, , (Fri Mar 7, 11:20 am)
Re: Linux 2.6.25-rc4, Ingo Molnar, (Fri Mar 7, 5:02 am)
Re: Linux 2.6.25-rc4, Paul Mackerras, (Fri Mar 7, 5:59 am)
Re: Linux 2.6.25-rc4, Jens Axboe, (Thu Mar 6, 9:12 am)
Re: Linux 2.6.25-rc4, FUJITA Tomonori, (Wed Mar 5, 4:09 am)
Re: Linux 2.6.25-rc4, Grant Grundler, (Wed Mar 5, 12:46 pm)
speck-geostationary