Home » Mailing list archives » linux-kernel » 2008 » March » 6

[PATCH] locomo.c: convert strncpy(x, y, sizeof(x)) to strlcpy

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin
Subject: [PATCH] locomo.c: convert strncpy(x, y, sizeof(x)) to strlcpy
Date: Thursday, March 6, 2008 - 6:08 am

This patch was not yet tested. Please confirm it's right.
---
strncpy does not append '\0' if the length of the source string equals
the size parameter, strlcpy does.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c
index ae21755..89b2328 100644
--- a/arch/arm/common/locomo.c
+++ b/arch/arm/common/locomo.c
@@ -516,7 +516,7 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info)
 		goto out;
 	}
 
-	strncpy(dev->dev.bus_id, info->name, sizeof(dev->dev.bus_id));
+	strlcpy(dev->dev.bus_id, info->name, sizeof(dev->dev.bus_id));
 	/*
 	 * If the parent device has a DMA mask associated with it,
 	 * propagate it down to the children.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] locomo.c: convert strncpy(x, y, sizeof(x)) to strlcpy, Roel Kluin, (Thu Mar 6, 6:08 am)
Re: [PATCH] locomo.c: convert strncpy(x, y, sizeof(x)) to ..., H. Peter Anvin, (Thu Mar 6, 2:44 pm)
Re: [PATCH] locomo.c: convert strncpy(x, y, sizeof(x)) to ..., Roel Kluin, (Thu Mar 6, 4:35 pm)