Home » Mailing list archives » linux-kernel » 2008 » March » 6

Re: [PATCH -mm 2/2] send_sigqueue: don't forget about handle_stop_signal()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland McGrath
Subject: Re: [PATCH -mm 2/2] send_sigqueue: don't forget about handle_stop_signal()
Date: Thursday, March 6, 2008 - 4:06 am

> send_group_sigqueue() calls handle_stop_signal(), send_sigqueue() doesn't.

Yes, it was wrong.  I think I noticed it long ago and never bothered with
it because send_sigqueue is nearly unused.  SIGEV_THREAD_ID is in practice
only used internally by libc (timer_create) to implement SIGEV_THREAD, and
it never uses any of the signals handle_stop_signal checks for.

Your fix is good and should go in.
I'd bet noone will ever notice the difference now or ever.


Thanks,
Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -mm 2/2] send_sigqueue: don't forget about handle_s ..., Oleg Nesterov, (Wed Mar 5, 2:53 pm)
Re: [PATCH -mm 2/2] send_sigqueue: don't forget about hand ..., Oleg Nesterov, (Wed Mar 5, 4:52 pm)
Re: [PATCH -mm 2/2] send_sigqueue: don't forget about hand ..., Roland McGrath, (Thu Mar 6, 4:06 am)