login
Header Space

 
 

Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Christoph Lameter <clameter@...>
Cc: David Miller <davem@...>, <netdev@...>, <linux-kernel@...>, <yanmin_zhang@...>, <dada1@...>
Date: Wednesday, March 5, 2008 - 10:57 pm

On Wed, Mar 05, 2008 at 01:06:30PM -0800, Christoph Lameter wrote:

That's what callers expect when they pass the HWCACHE flag. Wouldn't it
be logical to fix the callers if you think it costs too much memory with
not enough improvement?

 

There looks like definitely some networking slabs that pass the flag
and can be non-power-of-2. And don't forget cachelines can be anywhere
up to 256 bytes in size. So yeah it definitely makes sense to merge
the patch and then examine the callers if you feel strongly about it.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Mon Mar 3, 3:08 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Mon Mar 3, 4:10 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Mon Mar 3, 5:16 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Wed Mar 5, 5:06 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Nick Piggin, (Wed Mar 5, 10:57 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 6:56 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 10:26 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 10:54 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 11:18 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 11:58 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Mon Mar 3, 5:32 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Wed Mar 5, 4:56 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 6:53 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 10:20 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 10:27 pm)
Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment, Christoph Lameter, (Thu Mar 6, 10:33 pm)
[rfc][patch 3/3] use SLAB_ALIGN_SMP, Nick Piggin, (Mon Mar 3, 5:36 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Eric Dumazet, (Mon Mar 3, 5:53 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Nick Piggin, (Mon Mar 3, 8:41 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Eric Dumazet, (Mon Mar 3, 9:00 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Nick Piggin, (Mon Mar 3, 9:46 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Pekka Enberg, (Mon Mar 3, 9:53 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Christoph Lameter, (Mon Mar 3, 3:09 pm)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Nick Piggin, (Mon Mar 3, 4:10 pm)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Christoph Lameter, (Mon Mar 3, 4:12 pm)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Nick Piggin, (Mon Mar 3, 4:18 pm)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Christoph Lameter, (Mon Mar 3, 5:14 pm)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Eric Dumazet, (Mon Mar 3, 10:15 am)
Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP, Christoph Lameter, (Mon Mar 3, 3:10 pm)
[rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Mon Mar 3, 5:35 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Mon Mar 3, 3:06 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Mon Mar 3, 4:03 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Mon Mar 3, 4:09 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Mon Mar 3, 4:12 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Mon Mar 3, 4:17 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Mon Mar 3, 4:24 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Mon Mar 3, 5:31 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Fri Mar 7, 12:37 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Fri Mar 7, 1:11 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Fri Mar 7, 1:19 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Fri Mar 7, 1:26 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Tue Mar 11, 3:13 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Wed Mar 12, 2:21 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Fri Mar 7, 1:37 am)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Nick Piggin, (Tue Mar 4, 8:16 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Pekka Enberg, (Mon Mar 3, 4:41 pm)
Re: [rfc][patch 2/3] slab: introduce SMP alignment, Christoph Lameter, (Mon Mar 3, 5:23 pm)
speck-geostationary