login
Header Space

 
 

Re: [PATCH] NUMA slab allocator migration bugfix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Joe Korty <joe.korty@...>
Cc: <linux-kernel@...>, <npiggin@...>, <davem@...>
Date: Wednesday, March 5, 2008 - 7:02 pm

On Wed, 5 Mar 2008, Joe Korty wrote:


The new slab is allocated for the node that was determined earlier and 
entered into the slab queues for that node. Howver, during the alloc we 
were rescheduled.

Then we find ourselves on another processor and recalculate the ac 
pointer. If we now retry then there is the danger of getting off node 
objects into the per cpu queue. Which may cause the wrong lock to be taken 
when draining queues. Sucks because it can cause data corruption. Same as
the other issues resolved by GFP_THISNODE.

Acked-by: Christoph Lameter <clameter@sgi.com>

Will queue it.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] NUMA slab allocator migration bugfix, Joe Korty, (Wed Mar 5, 6:33 pm)
Re: [PATCH] NUMA slab allocator migration bugfix, Christoph Lameter, (Wed Mar 5, 7:02 pm)
speck-geostationary