[PATCH 1/3] ide: remove ->extra field from struct ide_port_info

Previous thread: [RFC,PATCH 2/2] __group_complete_signal: fix? signal load-balancing by Oleg Nesterov on Wednesday, March 5, 2008 - 3:43 pm. (3 messages)

Next thread: [PATCH 2/3] ide: remove ide_dma_iobase() by Bartlomiej Zolnierkiewicz on Wednesday, March 5, 2008 - 4:01 pm. (1 message)
From: Bartlomiej Zolnierkiewicz
Date: Wednesday, March 5, 2008 - 4:00 pm

Always setup hwif->extra_base in ide_iomio_dma() and remove
no longer needed ->extra field from struct ide_port_info.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-dma.c          |    3 +--
 drivers/ide/pci/hpt34x.c       |    2 --
 drivers/ide/pci/hpt366.c       |    6 ------
 drivers/ide/pci/pdc202xx_old.c |    2 --
 include/linux/ide.h            |    1 -
 5 files changed, 1 insertion(+), 13 deletions(-)

Index: b/drivers/ide/ide-dma.c
===================================================================
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -850,8 +850,7 @@ static int ide_iomio_dma(ide_hwif_t *hwi
 	printk(KERN_INFO "    %s: BM-DMA at 0x%04lx-0x%04lx",
 	       hwif->name, base, base + 7);
 
-	if (hwif->cds->extra)
-		hwif->extra_base = base + (hwif->channel ? 8 : 16);
+	hwif->extra_base = base + (hwif->channel ? 8 : 16);
 
 	return 0;
 }
Index: b/drivers/ide/pci/hpt34x.c
===================================================================
--- a/drivers/ide/pci/hpt34x.c
+++ b/drivers/ide/pci/hpt34x.c
@@ -130,7 +130,6 @@ static const struct ide_port_info hpt34x
 	{ /* 0 */
 		.name		= "HPT343",
 		.init_chipset	= init_chipset_hpt34x,
-		.extra		= 16,
 		.port_ops	= &hpt34x_port_ops,
 		.host_flags	= IDE_HFLAGS_HPT34X | IDE_HFLAG_NON_BOOTABLE,
 		.pio_mask	= ATA_PIO5,
@@ -138,7 +137,6 @@ static const struct ide_port_info hpt34x
 	{ /* 1 */
 		.name		= "HPT345",
 		.init_chipset	= init_chipset_hpt34x,
-		.extra		= 16,
 		.port_ops	= &hpt34x_port_ops,
 		.host_flags	= IDE_HFLAGS_HPT34X | IDE_HFLAG_OFF_BOARD,
 		.pio_mask	= ATA_PIO5,
Index: b/drivers/ide/pci/hpt366.c
===================================================================
--- a/drivers/ide/pci/hpt366.c
+++ b/drivers/ide/pci/hpt366.c
@@ -1428,7 +1428,6 @@ static const struct ide_port_info hpt366
 		 * Bit 4 is for the primary channel, bit 5 for the secondary.
 		 */
 ...
Previous thread: [RFC,PATCH 2/2] __group_complete_signal: fix? signal load-balancing by Oleg Nesterov on Wednesday, March 5, 2008 - 3:43 pm. (3 messages)

Next thread: [PATCH 2/3] ide: remove ide_dma_iobase() by Bartlomiej Zolnierkiewicz on Wednesday, March 5, 2008 - 4:01 pm. (1 message)