[PATCH] checkpatch: v3 - Make some text more consinstent and informative

Previous thread: [PATCH] netfilter: replace horrible hack with ksize() by Pekka J Enberg on Wednesday, March 5, 2008 - 2:20 pm. (13 messages)

Next thread: [PATCH -mm 1/2] send_sigqueue: don't take rcu lock by Oleg Nesterov on Wednesday, March 5, 2008 - 2:53 pm. (1 message)
From: Paolo Ciarrocchi
Date: Wednesday, March 5, 2008 - 2:39 pm

Hi Andy,
Now messages about missing spaces or not needed spaces are in the format:
space is required
space is not required

New in v2: Fix some spelling mistakes noted by Joe Perches.
New in v3: Fix a spelling error reported by Roel Kluin

Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
 checkpatch.pl |   30 +++++++++++++++---------------
 1 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/checkpatch.pl b/checkpatch.pl
index 2a7cef9..432729b 100755
--- a/checkpatch.pl
+++ b/checkpatch.pl
@@ -1005,7 +1005,7 @@ sub process {
 					$herecurr);
 			}
 			if ($line =~ /^\s*signed-off-by:\S/i) {
-				WARN("need space after Signed-off-by:\n" .
+				WARN("space is required after Signed-off-by:\n" .
 					$herecurr);
 			}
 		}
@@ -1340,7 +1340,7 @@ sub process {
 			} elsif ("$ctx$name" =~ /$Type$/) {
 
 			} else {
-				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+				WARN("space is not required between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
 # Check operator spacing.
@@ -1424,7 +1424,7 @@ sub process {
 				} elsif ($op eq ';') {
 					if ($ctx !~ /.x[WEBC]/ &&
 					    $cc !~ /^\\/ && $cc !~ /^;/) {
-						ERROR("need space after that '$op' $at\n" . $hereptr);
+						ERROR("space is required after that '$op' $at\n" . $hereptr);
 					}
 
 				# // is a comment
@@ -1433,13 +1433,13 @@ sub process {
 				# -> should have no spaces
 				} elsif ($op eq '->') {
 					if ($ctx =~ /Wx.|.xW/) {
-						ERROR("no spaces around that '$op' $at\n" . $hereptr);
+						ERROR("spaces are not required around that '$op' $at\n" . $hereptr);
 					}
 
 				# , must have a space on the right.
 				} elsif ($op eq ',') {
 					if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
-						ERROR("need space after that '$op' $at\n" . $hereptr);
+						ERROR("space is required after that '$op' $at\n" . $hereptr);
 					}
 
 				# '*' as part of a type definition -- reported already.
@@ -1452,10 ...
Previous thread: [PATCH] netfilter: replace horrible hack with ksize() by Pekka J Enberg on Wednesday, March 5, 2008 - 2:20 pm. (13 messages)

Next thread: [PATCH -mm 1/2] send_sigqueue: don't take rcu lock by Oleg Nesterov on Wednesday, March 5, 2008 - 2:53 pm. (1 message)