x86_64: set cfg_size for AMD Family 10h in case MMCONFIG should be material for 2.6.25

Previous thread: Linux 2.6.25-rc4 by Linus Torvalds on Tuesday, March 4, 2008 - 10:03 pm. (80 messages)

Next thread: [RFC][PATCH 0/1]a new optional function for task assignment to cgroup by Kazunaga Ikeno on Tuesday, March 4, 2008 - 10:39 pm. (5 messages)
From: Yinghai Lu
Date: Tuesday, March 4, 2008 - 10:04 pm

Ingo/greg,

one patch in x86.git#testing

    x86_64: set cfg_size for AMD Family 10h in case MMCONFIG

    reuse pci_cfg_space_size but skip check pci express and pci-x CAP ID.

should be get into 2.6.25. instead of waiting for 2.6.26

it just one quirk to update AMD fam10h cfg_size if MMCONFIG is there.

otherwise lspci -vvxxxx still report 512 for those NB.

YH
--

From: Ingo Molnar
Date: Wednesday, March 5, 2008 - 12:05 am

i have no objections and the patch has been in the tree for some time. 
Greg, if you agree, could you send it to Linus. (or i can do it too if 
you Ack the change)

	Ingo

------------------->
Subject: x86_64: set cfg_size for AMD Family 10h in case MMCONFIG
From: Yinghai Lu <Yinghai.Lu@Sun.COM>
Date: Fri, 15 Feb 2008 01:32:50 -0800

reuse pci_cfg_space_size but skip check pci express and pci-x CAP ID.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
===================================================================
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/pci/fixup.c |   17 +++++++++++++++++
 drivers/pci/probe.c  |   11 ++++++++++-
 include/linux/pci.h  |    1 +
 3 files changed, 28 insertions(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/pci/fixup.c
===================================================================
--- linux-x86.q.orig/arch/x86/pci/fixup.c
+++ linux-x86.q/arch/x86/pci/fixup.c
@@ -493,3 +493,20 @@ static void __devinit pci_siemens_interr
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SIEMENS, 0x0015,
 			  pci_siemens_interrupt_controller);
+
+/*
+ * Regular PCI devices have 256 bytes, but AMD Family 10h Opteron ext config
+ * have 4096 bytes.  Even if the device is capable, that doesn't mean we can
+ * access it.  Maybe we don't have a way to generate extended config space
+ * accesses.   So check it
+ */
+static void fam10h_pci_cfg_space_size(struct pci_dev *dev)
+{
+	dev->cfg_size = pci_cfg_space_size_ext(dev, 0);
+}
+
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, 0x1200, fam10h_pci_cfg_space_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, 0x1201, fam10h_pci_cfg_space_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, 0x1202, fam10h_pci_cfg_space_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, 0x1203, ...
From: Greg KH
Date: Wednesday, March 5, 2008 - 12:35 am

Feel free to send it and add my:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

thanks,

greg k-h
--

Previous thread: Linux 2.6.25-rc4 by Linus Torvalds on Tuesday, March 4, 2008 - 10:03 pm. (80 messages)

Next thread: [RFC][PATCH 0/1]a new optional function for task assignment to cgroup by Kazunaga Ikeno on Tuesday, March 4, 2008 - 10:39 pm. (5 messages)