[PATCH 8/8] debugfs: fix sparse warnings

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Tuesday, March 4, 2008 - 4:18 pm

From: Harvey Harrison <harvey.harrison@gmail.com>

extern does not belong in C files, move declaration to linux/debugfs.h
fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 fs/debugfs/inode.c      |    4 ----
 include/linux/debugfs.h |    5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index d26e282..e9602d8 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -29,10 +29,6 @@
 
 #define DEBUGFS_MAGIC	0x64626720
 
-/* declared over in file.c */
-extern struct file_operations debugfs_file_operations;
-extern struct inode_operations debugfs_link_operations;
-
 static struct vfsmount *debugfs_mount;
 static int debugfs_mount_count;
 
diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index f592d6d..7266124 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper {
 };
 
 #if defined(CONFIG_DEBUG_FS)
+
+/* declared over in file.c */
+extern const struct file_operations debugfs_file_operations;
+extern const struct inode_operations debugfs_link_operations;
+
 struct dentry *debugfs_create_file(const char *name, mode_t mode,
 				   struct dentry *parent, void *data,
 				   const struct file_operations *fops);
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/8] driver core: fix up Kconfig text for CONFIG_SY ..., Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 2/8] sysfs: CONFIG_SYSFS_DEPRECATED fix, Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 3/8] kobject: properly initialize ksets, Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 4/8] PM: Do not acquire device semaphores upfront d ..., Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 5/8] PM: fix new mutex-locking bug in the PM core, Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 6/8] driver core: Remove dpm_sysfs_remove() from er ..., Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 7/8] Driver core: Fix cleanup when failing device_a ..., Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)
[PATCH 8/8] debugfs: fix sparse warnings, Greg Kroah-Hartman, (Tue Mar 4, 4:18 pm)