[PATCH 6/8] driver core: Remove dpm_sysfs_remove() from error path of device_add()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Rafael J. Wysocki <rjw@...>, Greg Kroah-Hartman <gregkh@...>
Date: Tuesday, March 4, 2008 - 7:18 pm

From: Rafael J. Wysocki <rjw@sisk.pl>

Since device_pm_remove(dev) calls dpm_sysfs_remove(dev), it's
incorrect to call the latter after the former in the device_add()
error path.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 1e2e0fa..7f59c2f 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -839,7 +839,6 @@ int device_add(struct device *dev)
 	return error;
  BusError:
 	device_pm_remove(dev);
-	dpm_sysfs_remove(dev);
  PMError:
 	if (dev->bus)
 		blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 8/8] debugfs: fix sparse warnings, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 7/8] Driver core: Fix cleanup when failing device_add..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 6/8] driver core: Remove dpm_sysfs_remove() from erro..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 5/8] PM: fix new mutex-locking bug in the PM core, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 4/8] PM: Do not acquire device semaphores upfront dur..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 3/8] kobject: properly initialize ksets, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 2/8] sysfs: CONFIG_SYSFS_DEPRECATED fix, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 1/8] driver core: fix up Kconfig text for CONFIG_SYSF..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)