login
Header Space

 
 

[PATCH 3/8] kobject: properly initialize ksets

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Greg Kroah-Hartman <gregkh@...>, Kay Sievers <kay.sievers@...>, Hannes Reinecke <hare@...>
Date: Tuesday, March 4, 2008 - 7:18 pm

kset_initialize was calling kobject_init_internal() which didn't
initialize the kobject as well as kobject_init() was.  So have
kobject_init() call kobject_init_internal() and move the logic to
initalize the kobject there.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/kobject.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index d784dae..0d03252 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -153,6 +153,10 @@ static void kobject_init_internal(struct kobject *kobj)
 		return;
 	kref_init(&kobj->kref);
 	INIT_LIST_HEAD(&kobj->entry);
+	kobj->state_in_sysfs = 0;
+	kobj->state_add_uevent_sent = 0;
+	kobj->state_remove_uevent_sent = 0;
+	kobj->state_initialized = 1;
 }
 
 
@@ -289,13 +293,8 @@ void kobject_init(struct kobject *kobj, struct kobj_type *ktype)
 		dump_stack();
 	}
 
-	kref_init(&kobj->kref);
-	INIT_LIST_HEAD(&kobj->entry);
+	kobject_init_internal(kobj);
 	kobj->ktype = ktype;
-	kobj->state_in_sysfs = 0;
-	kobj->state_add_uevent_sent = 0;
-	kobj->state_remove_uevent_sent = 0;
-	kobj->state_initialized = 1;
 	return;
 
 error:
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 8/8] debugfs: fix sparse warnings, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 7/8] Driver core: Fix cleanup when failing device_add..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 6/8] driver core: Remove dpm_sysfs_remove() from erro..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 5/8] PM: fix new mutex-locking bug in the PM core, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 4/8] PM: Do not acquire device semaphores upfront dur..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 3/8] kobject: properly initialize ksets, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 2/8] sysfs: CONFIG_SYSFS_DEPRECATED fix, Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
[PATCH 1/8] driver core: fix up Kconfig text for CONFIG_SYSF..., Greg Kroah-Hartman, (Tue Mar 4, 7:18 pm)
speck-geostationary