Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alan Stern <stern@...>
Cc: David Brownell <david-b@...>, LKML <linux-kernel@...>, <0x0007@...>, USB list <linux-usb@...>
Date: Tuesday, March 4, 2008 - 2:53 pm

On Tue, 4 Mar 2008, Alan Stern wrote:

I'm not sure, but do you mean:

--- linux-2.6/drivers/usb/host/ehci-hcd.c	2008-02-24 22:25:54.000000000 +0100
+++ linux-2.6/drivers/usb/host/ehci-hcd.c.edited	2008-03-04 19:46:13.000000000 +0100
@@ -284,7 +284,10 @@ static void ehci_iaa_watchdog(unsigned l
  	u32			status, cmd;

  	spin_lock_irqsave (&ehci->lock, flags);
-	WARN_ON(!ehci->reclaim);
+	if (unlikely(!ehci->reclaim ||
+			!HC_IS_RUNNING(ehci_to_hcd(ehci)->state) ||
+			timer_pending(&ehci->iaa_watchdog))
+	goto done;

  	status = ehci_readl(ehci, &ehci->regs->status);
  	cmd = ehci_readl(ehci, &ehci->regs->command);


Thanks,
Christian.
-- 
BOFH excuse #189:

SCSI's too wide.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Sun Mar 2, 8:05 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Andrew Morton, (Tue Mar 4, 3:49 am)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Tue Mar 4, 4:01 am)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Andrew Morton, (Tue Mar 4, 4:10 am)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Mon Mar 3, 6:38 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Alan Stern, (Tue Mar 4, 12:29 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, David Brownell, (Tue Mar 4, 4:51 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Alan Stern, (Tue Mar 4, 4:57 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, David Brownell, (Tue Mar 4, 6:01 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Tue Mar 4, 7:15 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, David Brownell, (Tue Mar 4, 8:30 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Tue Mar 4, 9:15 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, David Brownell, (Wed Mar 5, 12:25 am)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Wed Mar 5, 6:59 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Fri Mar 7, 3:51 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Christian Kujau, (Tue Mar 4, 2:53 pm)
Re: WARNING: at drivers/usb/host/ehci-hcd.c:287, Alan Stern, (Tue Mar 4, 4:27 pm)