Re: 2.6.25-rc regression: kernel panic on boot

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: Zhang, Rui <rui.zhang@...>, linux-kernel <linux-kernel@...>, <kay.sievers@...>, Andrew Morton <akpm@...>, Rafael J. Wysocki <rjw@...>, Linus Torvalds <torvalds@...>, Alexey Dobriyan <adobriyan@...>
Date: Tuesday, March 4, 2008 - 9:54 am

* Greg KH <gregkh@suse.de> wrote:


we _really_ must handle this differently and this _is_ a regression that 
multiple people have spent hours on bisecting already ...

So "enable CONFIG_SYSFS_DEPCRECATED" is _NOT_ the right answer, and this 
has been pointed out to you in the past.

the problem is that SYSFS_DEPRECATED changed its meaning mid-course. Now 
it means a different set of udev breakages. The correct way is to 
_RENAME_ that darn option to SYSFS_DEPRECATED_V2 (via the patch below), 
and to discontinue the user-configurability of the old SYSFS_DEPRECATED 
option. Viola, things work just fine - and the fact of SYSFS_DEPRECATED 
changing its meaning is documented as well.

this way any tester who comes over the 'make oldconfig' route is not hit 
in the head with a nasty regression ...

tested patch below. (and this is one of those rare cases where 'select' 
is the right thing to do in a Kconfig entry)

	Ingo

---------------------->
Subject: sysfs: CONFIG_SYSFS_DEPRECATED fix
From: Ingo Molnar <mingo@elte.hu>
Date: Tue Mar 04 14:35:21 CET 2008

CONFIG_SYSFS_DEPRECATED=y changed its meaning recently and causes
regressions in working setups that had SYSFS_DEPRECATED disabled.

so rename it to SYSFS_DEPRECATED_V2 so that testers pick up the new
default via 'make oldconfig', even if their old .config's disabled
CONFIG_SYSFS_DEPRECATED ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 init/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux/init/Kconfig
===================================================================
--- linux.orig/init/Kconfig
+++ linux/init/Kconfig
@@ -367,9 +367,13 @@ config RESOURCE_COUNTERS
 	depends on CGROUPS
 
 config SYSFS_DEPRECATED
+	bool
+
+config SYSFS_DEPRECATED_V2
 	bool "Create deprecated sysfs files"
 	depends on SYSFS
 	default y
+	select SYSFS_DEPRECATED
 	help
 	  This option creates deprecated symlinks such as the
 	  "device"-link, the <subsystem>:<name>-link, and the
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc regression: kernel panic on boot, Zhang, Rui, (Sun Mar 2, 7:25 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Greg KH, (Mon Mar 3, 6:42 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Ingo Molnar, (Tue Mar 4, 9:54 am)
Re: 2.6.25-rc regression: kernel panic on boot, Alexey Dobriyan, (Wed Mar 5, 6:16 am)
Re: 2.6.25-rc regression: kernel panic on boot, Greg KH, (Wed Mar 5, 11:37 am)
Re: 2.6.25-rc regression: kernel panic on boot, Ingo Molnar, (Wed Mar 5, 9:29 am)
Re: 2.6.25-rc regression: kernel panic on boot, Andrew Morton, (Tue Mar 4, 2:43 pm)
Re: [dm-devel] Re: 2.6.25-rc regression: kernel panic on boot, Alasdair G Kergon, (Tue Mar 4, 9:19 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Greg KH, (Tue Mar 4, 3:33 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Linus Torvalds, (Tue Mar 4, 4:04 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Greg KH, (Tue Mar 4, 4:24 pm)
Re: 2.6.25-rc regression: kernel panic on boot, Ingo Molnar, (Wed Mar 5, 9:25 am)
Re: 2.6.25-rc regression: kernel panic on boot, Zhang, Rui, (Mon Mar 3, 2:33 pm)