Re: [PATCH] evdev: Release eventual input device grabs when getting disconnected

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Berg
Date: Monday, March 31, 2008 - 2:02 pm

> --- a/drivers/input/evdev.c

You might want to insert a comment about why this is safe and doesn't
race since it's not entirely trivial to see because everything else that
manipulates the grab needs to take the mutex. In fact, I'm not entirely
sure it's race-free but at least it can't race against the ioctl handler
because by this time ->exist will be 0.

johannes
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] evdev: Release eventual input device grabs whe ..., Johannes Berg, (Mon Mar 31, 2:02 pm)
Re: [PATCH] evdev: Release eventual input device grabs whe ..., Benjamin Herrenschmidt, (Mon Mar 31, 4:12 pm)
Re: [PATCH] evdev: Release eventual input device grabs whe ..., Benjamin Herrenschmidt, (Mon Mar 31, 6:01 pm)