login
Header Space

 
 

Re: style of function definitions (Re: [patch] bkl2mtd: cleanup)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Engelhardt <jengelh@...>
Cc: Oleg Verych <olecom@...>, Ingo Molnar <mingo@...>, Al Viro <viro@...>, Joern Engel <joern@...>, David Miller <davem@...>, <jirislaby@...>, <joe@...>, <tglx@...>, <linux-kernel@...>, Andy Whitcroft <apw@...>
Date: Sunday, March 30, 2008 - 11:37 pm

Jan Engelhardt @ Sun, Mar 30, 2008 at 6:31 AM:


i.e. zoo of proprietary versions, expensive, without reliable implementation
of basic tools and compilers, etc.

Historical UNIX(R) isn't that good at all. Now it's POSIX(R) forcing all
new development back.

http://kernelnewbies.org/olecom#trailing_comments_crap
http://kernelnewbies.org/olecom#trailing_multiline_comments_crap

Q: why every parameter is on new line?
A: thus we have more actual code line count

Q: why trailing comments on every parameter?
A: our C compiler have (had) 8 characters limit for variable names

Q: don't you think streaming editor can handle that?
A: our tools have not such thing

Q: you have multi-line trailing comments there, don't you know
   it complicates line-oriented grep-like text processing?
   why don't you write freely in comment block before function definition?
A: why do you care?

-- 
-o--=O`C
 #oo'L O
<___=E M
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Christoph Hellwig, (Wed Mar 26, 7:09 am)
[patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 6:14 am)
Re: [patch] bkl2mtd: cleanup, Al Viro, (Wed Mar 26, 6:48 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:10 am)
Re: style of function definitions (Re: [patch] bkl2mtd: clea..., Oleg Verych, (Sun Mar 30, 11:37 pm)
Re: [patch] bkl2mtd: cleanup, Joe Perches, (Wed Mar 26, 12:30 pm)
Re: [patch] bkl2mtd: cleanup, Jiri Slaby, (Wed Mar 26, 7:14 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:02 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:00 am)
Re: [patch] bkl2mtd: cleanup, Jörn, (Wed Mar 26, 6:57 am)
speck-geostationary