Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Huang, Ying <ying.huang@...>
Cc: <hpa@...>, <andi@...>, <mingo@...>, <tglx@...>, <linux-kernel@...>
Date: Sunday, March 30, 2008 - 12:25 am

Huang wrote:

This seems to be the descriptor for an incoming compressed
kernel image, right?  What is it doing in this patchset?

In your PATCH 4/4 to Documentation/i386/boot.txt, I can see
that there already existed documentation of these two payload
fields:

 0248/4	2.08+	payload_offset	Offset of kernel payload
 024C/4	2.08+	payload_length	Length of kernel payload

However, that documentation is just a useless rephrasing of the
variable names, with the added word "kernel".  Is this a compressed
kernel image?  If so, could that documentation be improved, perhaps as:

 0248/4	2.08+	payload_offset	Offset of compressed kernel payload
 024C/4	2.08+	payload_length	Length of compressed kernel payload

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct s..., Paul Jackson, (Sun Mar 30, 12:25 am)