Re: [PATCH 4/9] Netlink: Use generic LSM hook

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Ahmed S. Darwish <darwish.07@...>

Cc: Chris Wright <chrisw@...>, Stephen Smalley <sds@...>, James Morris <jmorris@...>, Eric Paris <eparis@...>, Casey Schaufler <casey@...>, David Woodhouse <dwmw2@...>, Andrew Morton <akpm@...>, LKML <linux-kernel@...>, Audit-ML <linux-audit@...>, LSM-ML <linux-security-module@...>

Subject: Re: [PATCH 4/9] Netlink: Use generic LSM hook

Date: Monday, March 3, 2008 - 7:33 pm

On Saturday 01 March 2008 2:56:22 pm Ahmed S. Darwish wrote:
quoted text> Don't use SELinux exported selinux_get_task_sid symbol.
> Use the generic LSM equivalent instead.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>

Reviewed-by: Paul Moore <paul.moore@hp.com>

quoted text> ---
>
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 1ab0da2..61fd277 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -54,7 +54,6 @@
>  #include <linux/mm.h>
>  #include <linux/types.h>
>  #include <linux/audit.h>
> -#include <linux/selinux.h>
>  #include <linux/mutex.h>
>
>  #include <net/net_namespace.h>
> @@ -1239,7 +1238,7 @@ static int netlink_sendmsg(struct kiocb *kiocb,
> struct socket *sock, NETLINK_CB(skb).pid	= nlk->pid;
>  	NETLINK_CB(skb).dst_group = dst_group;
>  	NETLINK_CB(skb).loginuid = audit_get_loginuid(current);
> -	selinux_get_task_sid(current, &(NETLINK_CB(skb).sid));
> +	security_task_getsecid(current, &(NETLINK_CB(skb).sid));
>  	memcpy(NETLINK_CREDS(skb), &siocb->scm->creds, sizeof(struct
> ucred));
>
>  	/* What can I do? Netlink is asynchronous, so that



-- 
paul moore
linux security @ hp
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH-v2 -mm 0/9] LSM-neutral Audit (SELinux audit separati..., Ahmed S. Darwish, (Sat Mar 1, 3:47 pm)

Re: [PATCH-v2 -mm 0/9] LSM-neutral Audit (SELinux audit sepa..., James Morris, (Wed Mar 5, 1:29 am)

[PATCH 9/9] Audit: Final renamings and cleanup, Ahmed S. Darwish, (Sat Mar 1, 4:05 pm)

Re: [PATCH 9/9] Audit: Final renamings and cleanup, James Morris, (Mon Mar 3, 5:21 pm)

[PATCH 8/9] SELinux: use new audit hooks, remove redundant e..., Ahmed S. Darwish, (Sat Mar 1, 4:03 pm)

Re: [PATCH 8/9] SELinux: use new audit hooks, remove redunda..., James Morris, (Mon Mar 3, 5:20 pm)

[PATCH 7/9] Audit: internally use the new LSM audit hooks, Ahmed S. Darwish, (Sat Mar 1, 4:01 pm)

Re: [PATCH 7/9] Audit: internally use the new LSM audit hooks, Paul Moore, (Mon Mar 3, 7:51 pm)

Re: [PATCH 7/9] Audit: internally use the new LSM audit hooks, James Morris, (Tue Mar 4, 12:15 am)

Re: [PATCH 7/9] Audit: internally use the new LSM audit hooks, Ahmed S. Darwish, (Mon Mar 3, 11:31 pm)

Re: [PATCH 7/9] Audit: internally use the new LSM audit hooks, James Morris, (Tue Mar 4, 12:09 am)

Re: [PATCH 7/9] Audit: internally use the new LSM audit hooks, James Morris, (Mon Mar 3, 5:20 pm)

[PATCH 6/9] LSM/Audit: Introduce generic Audit LSM hooks, Ahmed S. Darwish, (Sat Mar 1, 4:00 pm)

Re: [PATCH 6/9] LSM/Audit: Introduce generic Audit LSM hooks, Paul Moore, (Mon Mar 3, 7:36 pm)

Re: [PATCH 6/9] LSM/Audit: Introduce generic Audit LSM hooks, James Morris, (Mon Mar 3, 5:20 pm)

[PATCH 5/9] SELinux: remove redundant exports, Ahmed S. Darwish, (Sat Mar 1, 3:58 pm)

Re: [PATCH 5/9] SELinux: remove redundant exports, Paul Moore, (Mon Mar 3, 7:41 pm)

Re: [PATCH 5/9] SELinux: remove redundant exports, James Morris, (Mon Mar 3, 5:20 pm)

[PATCH 4/9] Netlink: Use generic LSM hook, Ahmed S. Darwish, (Sat Mar 1, 3:56 pm)

Re: [PATCH 4/9] Netlink: Use generic LSM hook, Paul Moore, (Mon Mar 3, 7:33 pm)

Re: [PATCH 4/9] Netlink: Use generic LSM hook, James Morris, (Mon Mar 3, 5:19 pm)

Re: [PATCH 4/9] Netlink: Use generic LSM hook, David Miller, (Mon Mar 3, 5:30 pm)

[PATCH 3/9] Audit: use new LSM hooks instead of SELinux expo..., Ahmed S. Darwish, (Sat Mar 1, 3:54 pm)

Re: [PATCH 3/9] Audit: use new LSM hooks instead of SELinux ..., Paul Moore, (Mon Mar 3, 7:31 pm)

Re: [PATCH 3/9] Audit: use new LSM hooks instead of SELinux ..., James Morris, (Mon Mar 3, 5:19 pm)

[PATCH 2/9] SELinux: setup new inode/ipc getsecid hooks, Ahmed S. Darwish, (Sat Mar 1, 3:52 pm)

Re: [PATCH 2/9] SELinux: setup new inode/ipc getsecid hooks, Paul Moore, (Mon Mar 3, 7:25 pm)

Re: [PATCH 2/9] SELinux: setup new inode/ipc getsecid hooks, James Morris, (Mon Mar 3, 5:19 pm)

[PATCH 1/9] LSM: Introduce inode_getsecid and ipc_getsecid h..., Ahmed S. Darwish, (Sat Mar 1, 3:51 pm)

Re: [PATCH 1/9] LSM: Introduce inode_getsecid and ipc_getsec..., Paul Moore, (Mon Mar 3, 7:26 pm)

Re: [PATCH 1/9] LSM: Introduce inode_getsecid and ipc_getsec..., James Morris, (Mon Mar 3, 5:18 pm)


linux-kernel:
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
David Woodhouse	[GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more dr...
KAMEZAWA Hiroyuki	Re: 2.6.23-mm1
git:

linux-netdev:
David Miller	Re: [PATCH 3/3] Convert the UDP hash lock to RCU
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Evgeniy Polyakov	Re: 2.6.25-rc8: FTP transfer errors
openbsd-misc:

Re: [PATCH 4/9] Netlink: Use generic LSM hook

Online users