login
Header Space

 
 

[PATCH] fix mount option parsing for ext3/4

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ext4@...>
Cc: <linux-kernel@...>, <akpm@...>
Date: Monday, March 3, 2008 - 5:10 pm

Hello,

Noticed that the "resize" option won't be noticed as it comes after the NULL 
option, so if you try to mount (or in this case remount) with that option it 
won't be recognized.  Both ext3 and ext4 have this problem.  Thank you,

Signed-off-by: Josef Bacik <jbacik@redhat.com>

Index: linux-2.6/fs/ext3/super.c
===================================================================
--- linux-2.6.orig/fs/ext3/super.c
+++ linux-2.6/fs/ext3/super.c
@@ -806,8 +806,8 @@ static match_table_t tokens = {
 	{Opt_quota, "quota"},
 	{Opt_usrquota, "usrquota"},
 	{Opt_barrier, "barrier=%u"},
-	{Opt_err, NULL},
 	{Opt_resize, "resize"},
+	{Opt_err, NULL},
 };
 
 static ext3_fsblk_t get_sb_block(void **data)
Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c
+++ linux-2.6/fs/ext4/super.c
@@ -944,8 +944,8 @@ static match_table_t tokens = {
 	{Opt_mballoc, "mballoc"},
 	{Opt_nomballoc, "nomballoc"},
 	{Opt_stripe, "stripe=%u"},
-	{Opt_err, NULL},
 	{Opt_resize, "resize"},
+	{Opt_err, NULL},
 };
 
 static ext4_fsblk_t get_sb_block(void **data)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fix mount option parsing for ext3/4, Josef Bacik, (Mon Mar 3, 5:10 pm)
speck-geostationary