Re: [PATCH] block: fix residual byte count handling

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: FUJITA Tomonori <tomof@...>

Cc: <fujita.tomonori@...>, <jens.axboe@...>, <James.Bottomley@...>, <efault@...>, <akpm@...>, <linux-kernel@...>, <linux-ide@...>, <linux-scsi@...>, <jgarzik@...>

Subject: Re: [PATCH] block: fix residual byte count handling

Date: Monday, March 3, 2008 - 10:22 am

FUJITA Tomonori wrote:
quoted text>> At the end of blk_rq_map_user() together with data_len / extra_len
>> mangling or were you talking about James' original patch?
> 
> With my patch, at the end of blk_rq_map_user, we have:
> 
> 	if (len & queue_dma_alignment(q)) {
> 		unsigned int pad_len = (queue_dma_alignment(q) & ~len) + 1;
> 
> 		rq->extra_len += pad_len;
> 	}
> 
> 
> So no change as compared with 2.6.24?

Oh.. you killed sg list manipulation.  Many controllers do allow odd
bytes as the last sg entry but not all.  Also, if you append drain
buffer after it, it ends up with unaligned sg entry in the middle and
rq->data_len + rq->extra_len will overrun the sg entry after the drain
page which is really dangerous.

-- 
tejun
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

regression: CD burning (k3b) went broke, Mike Galbraith, (Thu Feb 21, 4:42 am)

Re: regression: CD burning (k3b) went broke, Jens Axboe, (Fri Feb 22, 3:32 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Sat Feb 23, 3:42 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Sun Feb 24, 3:54 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Tue Feb 26, 5:48 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Tue Feb 26, 9:36 am)

Re: regression: CD burning (k3b) went broke, Andrew Morton, (Tue Feb 26, 7:08 pm)

Re: regression: CD burning (k3b) went broke, Jeff Garzik, (Tue Feb 26, 8:46 pm)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Tue Feb 26, 10:58 pm)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Tue Feb 26, 10:24 pm)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Wed Feb 27, 2:00 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Wed Feb 27, 3:07 am)

Re: regression: CD burning (k3b) went broke, Tejun Heo, (Thu Feb 28, 3:43 am)

Re: regression: CD burning (k3b) went broke, Mike Galbraith, (Thu Feb 28, 4:20 am)

[PATCH] block: fix residual byte count handling, Tejun Heo, (Thu Feb 28, 4:50 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Thu Feb 28, 11:35 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Thu Feb 28, 11:46 am)

Re: [PATCH] block: fix residual byte count handling, James Bottomley, (Fri Feb 29, 12:47 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Fri Feb 29, 4:11 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Sat Mar 1, 2:17 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Sun Mar 2, 10:52 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Sun Mar 2, 10:40 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Sun Mar 2, 11:59 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 12:09 am)

[PATCH 1/2] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 2:08 am)

[PATCH] block: separate out padding from alignment, Tejun Heo, (Mon Mar 3, 2:10 am)

Re: [PATCH] block: separate out padding from alignment, James Bottomley, (Mon Mar 3, 2:27 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 4:26 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 5:21 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 8:17 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 9:38 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 9:50 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 9:55 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 10:01 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 10:22 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 10:52 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 6:44 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Mon Mar 3, 10:11 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Mon Mar 3, 10:32 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 4:53 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 4:59 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 5:29 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 5:06 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 5:22 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 5:30 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 5:35 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 5:40 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 5:46 am)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 8:37 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 8:40 am)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 9:30 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 9:50 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 12:17 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 12:42 pm)

Re: [PATCH] block: fix residual byte count handling, Boaz Harrosh, (Tue Mar 4, 2:26 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 2:35 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 3:19 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 7:33 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 7:54 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Tue Mar 4, 8:26 pm)

[PATCH] blk: missing add of padded bytes to io completion by..., Boaz Harrosh, (Wed Mar 5, 6:16 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., FUJITA Tomonori, (Thu Mar 6, 1:02 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Jens Axboe, (Wed Mar 5, 8:33 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Boaz Harrosh, (Wed Mar 5, 8:46 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Jens Axboe, (Wed Mar 5, 8:48 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Tejun Heo, (Wed Mar 5, 9:45 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Boaz Harrosh, (Wed Mar 5, 10:46 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Tejun Heo, (Wed Mar 5, 11:11 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Jens Axboe, (Wed Mar 5, 9:51 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., James Bottomley, (Wed Mar 5, 11:21 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., FUJITA Tomonori, (Thu Mar 6, 12:41 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Jens Axboe, (Thu Mar 6, 9:41 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., FUJITA Tomonori, (Thu Mar 20, 8:54 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Tejun Heo, (Thu Mar 6, 8:07 pm)

Re: [PATCH] blk: missing add of padded bytes to io completio..., FUJITA Tomonori, (Fri Mar 7, 11:07 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Tejun Heo, (Fri Mar 7, 9:06 pm)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Tejun Heo, (Wed Mar 5, 10:08 am)

Re: [PATCH] blk: missing add of padded bytes to io completio..., Mike Galbraith, (Wed Mar 5, 8:28 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 8:44 pm)

Re: [PATCH] block: fix residual byte count handling, FUJITA Tomonori, (Thu Mar 6, 12:56 am)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Thu Mar 6, 1:02 am)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 2:45 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 3:25 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 3:33 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 3:34 pm)

Re: [PATCH] block: fix residual byte count handling, James Bottomley, (Tue Mar 4, 2:27 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 2:33 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 8:45 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 8:39 am)

Re: [PATCH] block: fix residual byte count handling, walt, (Tue Mar 4, 1:34 pm)

Re: [PATCH] block: fix residual byte count handling, Tejun Heo, (Tue Mar 4, 1:59 pm)

Re: [PATCH] block: fix residual byte count handling, Kiyoshi Ueda, (Tue Mar 4, 3:42 pm)

Re: [PATCH] block: fix residual byte count handling, James Bottomley, (Tue Mar 4, 12:04 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 2:46 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 8:43 am)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 8:58 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 9:03 am)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 10:25 am)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 2:17 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 2:29 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 2:35 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 2:45 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 2:49 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 2:54 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Tue Mar 4, 3:26 pm)

Re: [PATCH] block: fix residual byte count handling, Jens Axboe, (Tue Mar 4, 3:28 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Christie, (Sun Mar 2, 2:46 pm)

Re: [PATCH] block: fix residual byte count handling, Mike Galbraith, (Sun Mar 2, 11:27 pm)

Re: [PATCH] block: fix residual byte count handling, James Bottomley, (Sat Mar 1, 11:19 am)

Navigation

Popular discussions


linux-kernel:
Peter Zijlstra	[PATCH 00/23] per device dirty throttling -v8
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking

Colocation donated by:

Online users

Syndicate