------------[ cut here ]------------ kernel BUG at net/mac80211/ieee80211.c:966! invalid opcode: 0000 [#1] SMP Modules linked in: iwl3945 mac80211 cfg80211 cryptomgr ecb arc4 blkcipher crypto_algapi snd_seq_oss snd_seq_device snd_seq_midi_event snd_seq snd_pcm_oss snd_mixer_oss nvidia(P) snd_hda_intel snd_pcm snd_timer snd snd_page_alloc Pid: 4472, comm: insmod Tainted: P (2.6.24 #4) EIP: 0060:[<f9982867>] EFLAGS: 00210246 CPU: 1 EIP is at ieee80211_alloc_hw+0x5a/0x2af [mac80211] EA...

Dallas USB speakers are buggy in more than one way. One of configs they offer does not work at all. Signed-off-by: Pavel Machek <pavel@suse.cz> diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index 257a4e1..b6b2490 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c int format; struct audioformat *fp; unsigned char *fmt, *csep; + int num; dev = chip->dev; /* parse the interface's altsettings */ iface = usb_ifnum_to_if(dev, iface_no); - for (i ...

System is a AMD K6-III/450. This is actually a 2.6.25-rcX issue that I'm just getting around to reporting. Sorry about that... ------------[ cut here ]------------ WARNING: at arch/x86/pci/irq.c:263 pirq_via586_get+0x23/0x42() Modules linked in: snd_emu10k1(+) snd_rawmidi firmware_class snd_ac97_codec ac97_bus snd_pcm snd_seq_device snd_timer snd_page_alloc snd_util_mem snd_hwdep snd soundcore ipv6 usbmouse usbhid ff_memless uhci_hcd ehci_hcd usbcore binfmt_misc Pid: 1784, comm: modprobe Not tainte...

From: Rafael J. Wysocki <rjw@sisk.pl> Implement new suspend and hibernation callbacks for the PCI bus type. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/pci/pci-driver.c | 371 ++++++++++++++++++++++++++++++++++++++++++----- include/linux/pci.h | 2 2 files changed, 334 insertions(+), 39 deletions(-) Index: linux-2.6/drivers/pci/pci-driver.c =================================================================== --- linux-2.6.orig/drivers/pci/pci-driver.c +++...

From: Rafael J. Wysocki <rjw@sisk.pl> Introduce 'struct pm_ops' and 'struct pm_ext_ops' representing suspend and hibernation operations for bus types, device classes and device types. Modify the PM core to use 'struct pm_ops' and 'struct pm_ext_ops' objects, if defined, instead of the ->suspend() and ->resume() or, respectively, ->suspend_late() and ->resume_early() callbacks that will be considered as legacy and gradually phased out. The main purpose of doing this is to sepa...

printk() works perfectly fine, no need to obfuscate code with snd_printk(). Signed-off-by: Pavel Machek <pavel@suse.cz> diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index f48838a..8056d8a 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -846,7 +850,7 @@ static int start_urbs(struct snd_usb_sub for (i = 0; i < subs->nurbs; i++) { snd_assert(subs->dataurb[i].urb, return -EINVAL); if (subs->ops.prepare(subs, runtime, subs->dataurb[i].urb) ...

proc-misc code is noticeably full of "if (de)" checks when PDE passed is always valid. Remove them. Addition of such check in proc_lookup_de() is for failed lookup case. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- fs/proc/generic.c | 33 ++++++++++--------------- fs/proc/inode.c | 69 +++++++++++++++++++++++++----------------------------- 2 files changed, 46 insertions(+), 56 deletions(-) --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -388,20 +388,18 @@ struct...

proc_subdir_lock protects only modifying and walking through PDE lists, so after we've found PDE to remove and actually removed it from lists, there is no need to hold proc_subdir_lock for the rest of operation. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- fs/proc/generic.c | 82 ++++++++++++++++++++++++++---------------------------- 1 file changed, 40 insertions(+), 42 deletions(-) --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -734,60 +734,58 @@ void free_proc_entry...

Any pci_* call before pci_enable_device() is questionable. I would put it after pci_enable_device(), unless there is a _strong_ reason. PCI devices are not considered available, with resources assigned, until pci_enable_device() I am also curious what irq events are being raised? That seems like another problem area to address, since pci_intx() is just a band-aid hiding that behavior. Jeff --

YH --

Cheers, Harvey --

Two sentences seem to be spliced into one in comment, fix that and fix english. Also fix codingstyle. Signed-off-by: Pavel Machek <pavel@suse.cz> diff --git a/include/sound/core.h b/include/sound/core.h index 4fc0235..452000d 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c int snd_card_file_remove(struct snd_card *card, struct file *file); #ifndef snd_card_set_dev -#define snd_card_set_dev(card,devptr) ((ca...

I should add that while watching a movie I noticed that video stutters every now and then, on an irregular basis. It lasts for approx a second each time. --

This doesn't sound good at all. Ingo, Thomas, are there any obvious candidates in the x86 and/or scheduler area that might cause it to happen? Rafael --

I'm testing that param at the moment, and while writing this response it happened again, meaning it didn't change anything.. I can't say for sure rc3 wasn't affected, I just never noticed the behavior during the 2-3 weeks I used it. regards, Richard --

Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/libata-core.c | 2 +- drivers/ata/libata-eh.c | 2 +- drivers/ata/pata_sil680.c | 6 +++++- include/linux/libata.h | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) Benjamin Herrenschmidt (1): pata_sil680: only enable MMIO on Cell blades Tejun Heo (1): libata: ATA_EHI_LPM should be...

We need to check for CONFIG_{CRIS,FRV} not {CRIS,FRV}. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- include/linux/ide.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/include/linux/ide.h =================================================================== --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -26,7 +26,7 @@ #include <asm/semaphore.h> #include <asm/mutex.h> -#if defined(CRIS) || defined(FRV) +#if defined(CONFIG_C...

There has been a lot of discussion on the mailing list regarding the various raid10 replicas so I benchmarked them compared to RAID 5 all with no optimizations and then re-ran the tests with optimizations, RAID 5 still generally turns out the best speed for sequential writes but raid10_f2 seems to overtake raid5 for reads. All tests used the XFS filesystem. For the results that show 0 this is when bonnie++ reports '+++' for the result which means it went too fast and needed to capture more da...

Hi Bart, This patchset refits the tape->merge_stage pipeline stage into tape->bh, a singly linked list of idetape_bh's, each of which is a tag attached to one or more pages serving as a buffer for data requests. The original functionality is kept wrt collecting data in the buffer and flushing it to the hardware when full. Currently, the data rq's are serialized on the block interface and it would probably be better to return immediately after issuing it over ide_do_drive_cmd() in order to ...

Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 58 ++++++++++++++++++++++++------------------------ 1 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index b5ec669..7fa0cc0 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -308,7 +308,7 @@ typedef struct ide_tape_obj { */ /* Data buffer size chosen based on the tape's recommendation */ - int stage_size; + int buffe...

Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 7fa0cc0..cf4351c 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -315,8 +315,7 @@ typedef struct ide_tape_obj { char *b_data; int b_count; - /* Pipeline parameters. */ - int pages_per_stage; + int pages_per_buffer; /* Wasted space in each stage */...

.. Just happened again. The machine resumed from RAM with no functioning USB. Still running the exact same 2.6.25-rc7 kernel as before, with the RTC conflict fixed. WTF? --

The "nv" driver is open source and it does not load any proprietary kernel module - so no need to avoid using that. It comes with Xorg and is loaded automatically if you have nvidia card. Parag --

Yes, it's so you can add a line without affecting the line before it, making a one-line patch into a two-line patch that's more likely to conflict. -hpa --

I think it's hard to ,,expect additions'' or just predict them. But smaller patch (diff) is one of things that makes sens of adding extra commas. I'm just pedantic here. -Jacek --