login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
29
Re: sound/core.h: evil #ifdefs
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Pavel Machek <pavel@...>
To: Harvey Harrison <harvey.harrison@...>
Cc: <perex@...>, kernel list <linux-kernel@...>, Trivial patch monkey <trivial@...>, <tiwai@...>
Subject:
Re: sound/core.h: evil #ifdefs
Date: Saturday, March 29, 2008 - 5:39 pm
Hi!
quoted text
> > snd_minor_info_oss_* is an function returning int _or_ comment, > > depending on config parameters. That is truly evil, fix it. > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > > > diff --git a/include/sound/core.h b/include/sound/core.h > > index 4fc0235..452000d 100644 > > --- a/include/sound/core.h > > +++ b/include/sound/core.h > > @@ -277,8 +277,8 @@ #ifdef CONFIG_SND_OSSEMUL > > int snd_minor_info_oss_init(void); > > int snd_minor_info_oss_done(void); > > #else > > -#define snd_minor_info_oss_init() /*NOP*/ > > -#define snd_minor_info_oss_done() /*NOP*/ > > +static inline snd_minor_info_oss_init(void) { return 0; } > static inline int snd_minor_info_oss_init(void) { return 0; } > > > +static inline snd_minor_info_oss_done(void) { return 0; } > static inline int snd_minor_info_oss_done(void) { return 0; } > > #endif
yep, thanks, scratch that patch. Pavel -- (english)
http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
sound/core.h: evil #ifdefs
, Pavel Machek
, (Sat Mar 29, 4:57 pm)
Re: sound/core.h: evil #ifdefs
, Harvey Harrison
, (Sat Mar 29, 5:00 pm)
Re: sound/core.h: evil #ifdefs
, Pavel Machek
, (Sat Mar 29, 5:39 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Michal Piotrowski
Re: 2.6.23-rc3-mm1
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Fred Tyler
Slow, persistent memory leak in 2.6.20
Roland Dreier
Re: Integration of SCST in the mainstream Linux kernel
git
:
linux-netdev
:
David Miller
[GIT]: Networking
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Antonio Almeida
HTB accuracy for high speed
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
516 guests
online.
Online users
usuwanieznamion
Syndicate