Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Christoph Lameter <clameter@...>
Cc: Rafael J. Wysocki <rjw@...>, Pawel Staszewski <pstaszewski@...>, LKML <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Natalie Protasevich <protasnb@...>
Date: Saturday, March 29, 2008 - 5:29 pm

On Sat, 29 Mar 2008, Christoph Lameter wrote:

Wrong.

It uses it's own logic for __GFP_ZERO *regardless* of size.


You don't have a f*cking clue about this cocde that you're supposed to be 
maintaining, do you?

See "slab_alloc()". See the code:

	if (unlikely((gfpflags & __GFP_ZERO) && object))
		memset(object, 0, c->objsize);

and see how it does it regardless of anything else.

In short, if *any* code-path calls down to any allocator from that routine 
with GFP_ZERO set, it's a bug. No ifs, buts or maybes about it. It 
shouldn't do that, because the actual memset() is done by slab_alloc(), 
and should not be done ANYWHERE ELSE.

It has *nothing* to do with "object is too big" or anything else.


No. I want you to admit the bugs in code you maintain. I want you to admit 
that slab_alloc() does the memset(), and should NEVER EVER use __GFP_ZERO
for the page allocations.

I have told you about a million times now that THIS HAS NOTHING TO DO WITH 
interrupts or HIGHMEM or *anything* else. This is purely a SLUB issue.

But don't worry. I already fixed it by reverting your broken commit. I 
just wish you could follow code that you are supposed to be maintaining.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Thu Mar 27, 6:53 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 6:24 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:12 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 12:18 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 6:58 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Peter Zijlstra, (Fri Mar 28, 7:00 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 7:13 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Peter Zijlstra, (Fri Mar 28, 7:44 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 7:16 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 7:31 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:17 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Fri Mar 28, 4:42 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 1:06 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Thu Mar 27, 10:30 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:10 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 12:47 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:28 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Mon Mar 31, 9:34 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 1:36 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Fri Mar 28, 4:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Haavard Skinnemoen, (Fri Mar 28, 7:29 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:11 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Yinghai Lu, (Thu Mar 27, 11:31 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Kamalesh Babulal, (Mon Mar 31, 6:14 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Mon Mar 31, 8:10 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Thu Mar 27, 11:24 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 12:00 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:25 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Sat Mar 29, 4:42 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Sat Mar 29, 5:29 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Mon Mar 31, 2:45 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Sat Mar 29, 7:52 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Mon Mar 31, 2:56 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 1:15 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 1:27 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:32 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 2:08 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 2:20 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 3:59 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 4:24 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Andrew Morton, (Fri Mar 28, 2:47 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:59 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:53 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:38 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Paweł Staszewski, (Fri Mar 28, 6:48 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Andrew Morton, (Fri Mar 28, 1:46 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 5:57 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Carlos R. Mafra, (Thu Mar 27, 8:18 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Thu Mar 27, 8:23 pm)