login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
29
Re: sound/core.h: evil #ifdefs
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Harvey Harrison <harvey.harrison@...>
To: Pavel Machek <pavel@...>
Cc: <perex@...>, kernel list <linux-kernel@...>, Trivial patch monkey <trivial@...>, <tiwai@...>
Subject:
Re: sound/core.h: evil #ifdefs
Date: Saturday, March 29, 2008 - 5:00 pm
On Sat, 2008-03-29 at 21:57 +0100, Pavel Machek wrote:
quoted text
> snd_minor_info_oss_* is an function returning int _or_ comment, > depending on config parameters. That is truly evil, fix it. > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > diff --git a/include/sound/core.h b/include/sound/core.h > index 4fc0235..452000d 100644 > --- a/include/sound/core.h > +++ b/include/sound/core.h > @@ -277,8 +277,8 @@ #ifdef CONFIG_SND_OSSEMUL > int snd_minor_info_oss_init(void); > int snd_minor_info_oss_done(void); > #else > -#define snd_minor_info_oss_init() /*NOP*/ > -#define snd_minor_info_oss_done() /*NOP*/ > +static inline snd_minor_info_oss_init(void) { return 0; }
static inline int snd_minor_info_oss_init(void) { return 0; }
quoted text
> +static inline snd_minor_info_oss_done(void) { return 0; }
static inline int snd_minor_info_oss_done(void) { return 0; }
quoted text
> #endif > > /* memory.c */ >
Cheers, Harvey --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
sound/core.h: evil #ifdefs
, Pavel Machek
, (Sat Mar 29, 4:57 pm)
Re: sound/core.h: evil #ifdefs
, Harvey Harrison
, (Sat Mar 29, 5:00 pm)
Re: sound/core.h: evil #ifdefs
, Pavel Machek
, (Sat Mar 29, 5:39 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
David Woodhouse
[PATCHv2 00/28] Allow built-in firmware to be accessed by request_firmware()
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Mike Travis
[RFC 00/15] x86_64: Optimize percpu accesses
git
:
linux-netdev
:
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich
[BUG] New Kernel Bugs
David Miller
[GIT]: Networking
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
690 guests
online.
Syndicate