login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
29
Re: Comma at end of enum lists
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Al Viro
Subject:
Re: Comma at end of enum lists
Date: Saturday, March 29, 2008 - 10:25 am
On Sat, Mar 29, 2008 at 10:20:38AM -0700, H. Peter Anvin wrote:
quoted text
> Jacek Luczak wrote: > >Hi All, > > > >I've found that in many enum lists, there's a comma at the end, e.g. > >(arch/x86/kernel/early_printk.c): > > > >enum { > > MAGIC1 = 0xBACCD00A, > > MAGIC2 = 0xCA110000, > > XOPEN = 5, > > XWRITE = 4, > >}; > > > >Just out of curiosity, is there any particular reason here (no word in > >CodingStyle about that). > > > > Yes, it's so you can add a line without affecting the line before it, > making a one-line patch into a two-line patch that's more likely to > conflict.
Note that doing that makes sense only when you can expect additions to the end and even then it's a matter of taste. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 10:00 am)
Re: Comma at end of enum lists
, Mikael Pettersson
, (Sat Mar 29, 10:19 am)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 10:20 am)
Re: Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 10:22 am)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 10:25 am)
Re: Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 10:26 am)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 10:28 am)
Re: Comma at end of enum lists
, Jan Engelhardt
, (Sat Mar 29, 10:42 am)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 10:52 am)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 10:54 am)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 10:56 am)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 10:57 am)
Re: Comma at end of enum lists
, Andreas Schwab
, (Sat Mar 29, 11:13 am)
Re: Comma at end of enum lists
, Jan Engelhardt
, (Sat Mar 29, 11:24 am)
Re: Comma at end of enum lists
, Andreas Schwab
, (Sat Mar 29, 11:47 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Dave Jones
Re: OT: character encodings (was: Linux 2.6.20-rc4)
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg
Re: [PATCH] kbuild: fix make V=1
Nick Piggin
Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Greg Kroah-Hartman
[PATCH 07/36] UIO: hold a reference to the device's owner while the device is open
git
:
Stephen R. van den Berg
Re: [RFC] origin link for cherry-pick and revert
Junio C Hamano
Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
James Henstridge
Re: VCS comparison table
linux-netdev
:
Jarek Poplawski
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek
Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath
Re: tcp bw in 2.6
Matt Mackall
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Guo-Fu Tseng
Re: jme: UDP checksum error, and lots of them
openbsd-misc
:
Claudio Jeker
Re: Vlan Tag on Vlan Tag (l2tunneling)
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Pieter Verberne
File collision while using pkg_add
Tomas Bodzar
bsd: uvm_mapent_alloc: out of static map entries
Community First Financial
Teacher A+ Loan
git-commits-head
:
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
tracing: protect reader of cmdline output
Linux Kernel Mailing List
kconfig: recalc symbol value before showing search results
Linux Kernel Mailing List
KVM: VMX: Clear CR4.VMXE in hardware_disable
Linux Kernel Mailing List
swsusp: provide users with a hint about the no_console_suspend option
Colocation donated by:
Syndicate