login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
29
Re: Comma at end of enum lists
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Al Viro <viro@...>
To: H. Peter Anvin <hpa@...>
Cc: Jacek Luczak <difrost.kernel@...>, <linux-kernel@...>
Subject:
Re: Comma at end of enum lists
Date: Saturday, March 29, 2008 - 1:25 pm
On Sat, Mar 29, 2008 at 10:20:38AM -0700, H. Peter Anvin wrote:
quoted text
> Jacek Luczak wrote: > >Hi All, > > > >I've found that in many enum lists, there's a comma at the end, e.g. > >(arch/x86/kernel/early_printk.c): > > > >enum { > > MAGIC1 = 0xBACCD00A, > > MAGIC2 = 0xCA110000, > > XOPEN = 5, > > XWRITE = 4, > >}; > > > >Just out of curiosity, is there any particular reason here (no word in > >CodingStyle about that). > > > > Yes, it's so you can add a line without affecting the line before it, > making a one-line patch into a two-line patch that's more likely to > conflict.
Note that doing that makes sense only when you can expect additions to the end and even then it's a matter of taste. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 1:00 pm)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 1:20 pm)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 1:25 pm)
Re: Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 1:26 pm)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 1:56 pm)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 1:57 pm)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 1:28 pm)
Re: Comma at end of enum lists
, Al Viro
, (Sat Mar 29, 1:52 pm)
Re: Comma at end of enum lists
, H. Peter Anvin
, (Sat Mar 29, 1:54 pm)
Re: Comma at end of enum lists
, Jan Engelhardt
, (Sat Mar 29, 1:42 pm)
Re: Comma at end of enum lists
, Mikael Pettersson
, (Sat Mar 29, 1:19 pm)
Re: Comma at end of enum lists
, Andreas Schwab
, (Sat Mar 29, 2:13 pm)
Re: Comma at end of enum lists
, Jan Engelhardt
, (Sat Mar 29, 2:24 pm)
Re: Comma at end of enum lists
, Andreas Schwab
, (Sat Mar 29, 2:47 pm)
Re: Comma at end of enum lists
, Jacek Luczak
, (Sat Mar 29, 1:22 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
KOSAKI Motohiro
[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Faik Uygur
Re: Linux 2.6.21-rc1
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Trent Piepho
[PATCH] [POWERPC] Improve (in|out)_beXX() asm code
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jens Axboe
Re: [BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
852 guests
online.
Online users
zeekec
mikulasring
Syndicate