login
Header Space

 
 

Re: [PATCH 2/2] x86: modify show_shared_cpu_map in intel_cacheinfo

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mike Travis <travis@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>
Date: Saturday, March 29, 2008 - 4:59 am

On Fri, Mar 28, 2008 at 7:19 PM, Mike Travis <travis@sgi.com> wrote:
But libbitmask has a bitmask_parsehex() too. (but thanks for the
pointer to this code).

Anyway, your above example is wrong, the most significant bits comes first:

ffff0000,00000000,00000000,00000000,00000000,00000000,00000000,00000000

This makes it not more readable, but I think readability isn't in this
case of that much importance.

I further think, this problem could be easily solved, if NR_CPUS and
possibly your nr_cpus_ids is somehow exported to user space.

With this information, the user is not surprised to see more that 1024
bits (=CPU_SETSIZE, which is currently the glibc constant for the
sched_{set,get}affinity() API). Also the glibc has the new variable
cpu_set_t size API (since 2.7).

Bert
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/2] x86: modify show_shared_cpu_map in intel_cac..., Bert Wesarg, (Sat Mar 29, 4:59 am)
speck-geostationary