On Fri, 28 Mar 2008 22:48:21 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

quoted text
> >> -	if (onlined_pages)
> >> +	if (onlined_pages) {
> >> +		struct memory_notify arg;
> >> +
> >> +		arg.start_pfn = pfn;  /* ? */
> >> +		arg.nr_pages = onlined_pages;
> >> +		arg.status_change_nid = -1;  /* ? */
> >> +
> >>  		memory_notify(MEM_ONLINE, &arg);
> >> +	}
> >>     
> > I think you should add "onlined" member instead of reusing nr_pages.
> >   
> 
> I suppose.  What would I put into nr_pages?  And anyway, there are no 
> users for this notification...
> 
My point is "Notifier" is expexted to work correctly and include precise
information regardless of users.

quoted text
> > But, in general, I have no objection to this way.
> >   
> 
> The refactoring in general?
> 

Separating online_pages() into some meaningful blocks. Then, you can
reuse some parts and avoid dupilication.

Thanks,
-Kame

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/