login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
29
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Bill Fink
Subject:
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
Date: Friday, March 28, 2008 - 9:52 pm
Typo in patch (see below): On Fri, 28 Mar 2008, Denys Vlasenko wrote:
quoted text
> On Friday 28 March 2008 01:52, David Miller wrote: > > From: Denys Vlasenko <vda.linux@googlemail.com> > > Date: Fri, 28 Mar 2008 00:36:59 +0100 > > > > > Can you add a comment which explains the intent? > > > > > > +struct sk_buff *dev_alloc_skb(unsigned int length) > > > +{ > > > + /* There is more code here than it seems: > > > + * __dev_alloc_skb is an inline */ > > > + return __dev_alloc_skb(length, GFP_ATOMIC); > > > +} > > > +EXPORT_SYMBOL(dev_alloc_skb); > > > > I've applied his patch already, if you want this comment > > please submit the patch to add it and also please use > > the correct formatting of the comment. > > Here it is. > > Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> > -- > vda > > --- net-2.6.26/net/core/skbuff.c Fri Mar 28 23:31:05 2008 > +++ net-2.6.26.comment/net/core/skbuff.c Fri Mar 28 23:33:03 2008 > @@ -277,6 +277,10 @@ > */ > struct sk_buff *dev_alloc_skb(unsigned int length) > { > + /* > + * There is more code here than it seems: > + * __def_alloc_skb is an inline
^ v
quoted text
> + */ > return __dev_alloc_skb(length, GFP_ATOMIC); > } > EXPORT_SYMBOL(dev_alloc_skb);
-Bill --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 0/7]: uninline some net related static inline in .h ...
, Ilpo Järvinen
, (Thu Mar 27, 5:37 am)
[PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
[PATCH 2/7] [NET]: uninline skb_pull, de-bloats a lot
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
[PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
[PATCH 4/7] [NET]: uninline skb_push, de-bloats a lot
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
[PATCH 5/7] [NET]: uninline dst_release
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
[PATCH 6/7] [NET]: uninline skb_trim, de-bloats
, Ilpo Järvinen
, (Thu Mar 27, 5:38 am)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Joe Perches
, (Thu Mar 27, 12:10 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, David Miller
, (Thu Mar 27, 3:04 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Denys Vlasenko
, (Thu Mar 27, 4:36 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Joe Perches
, (Thu Mar 27, 5:02 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, David Miller
, (Thu Mar 27, 5:04 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Matt Mackall
, (Thu Mar 27, 5:11 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, David Miller
, (Thu Mar 27, 5:43 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, David Miller
, (Thu Mar 27, 5:51 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, David Miller
, (Thu Mar 27, 5:52 pm)
Re: [PATCH 4/7] [NET]: uninline skb_push, de-bloats a lot
, David Miller
, (Thu Mar 27, 5:52 pm)
Re: [PATCH 5/7] [NET]: uninline dst_release
, David Miller
, (Thu Mar 27, 5:53 pm)
Re: [PATCH 6/7] [NET]: uninline skb_trim, de-bloats
, David Miller
, (Thu Mar 27, 5:54 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Joe Perches
, (Thu Mar 27, 5:54 pm)
Re: [PATCH 0/7]: uninline some net related static inline i ...
, David Miller
, (Thu Mar 27, 5:54 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Matt Mackall
, (Thu Mar 27, 6:18 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Arnaldo Carvalho de Melo
, (Thu Mar 27, 6:42 pm)
Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
, Ilpo Järvinen
, (Fri Mar 28, 12:56 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Denys Vlasenko
, (Fri Mar 28, 3:34 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, David Miller
, (Fri Mar 28, 3:57 pm)
Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Bill Fink
, (Fri Mar 28, 9:52 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge
Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin
Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade
Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson
Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev
:
Arnd Bergmann
Re: 64-bit net_device_stats
Stephens, Allan
RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka
[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang
Re: [PATCH] dm9601: handle corrupt mac address
David Miller
Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git
:
Junio C Hamano
Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano
Re: Handling large files with GIT
Karl
Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett
Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit
Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head
:
Linux Kernel Mailing List
MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List
regulator: update email address for Liam Girdwood
Linux Kernel Mailing List
[SCSI] ipr: add message to error table
Linux Kernel Mailing List
powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List
USB: omap_udc: sync with OMAP tree
openbsd-misc
:
Josh Grosse
Re: error : pkg add phpMyAdmin
Brian Candler
Re: OBSD's perspective on SELinux
Jacob Meuser
Re: /dev/audio: Device busy
David Vasek
Re: Inexpensive, low power, "wall wart" computer
William Boshuck
Re: Richard Stallman...
Colocation donated by:
Syndicate