Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roland McGrath <roland@...>
Cc: Andrew Morton <akpm@...>, Martin Schwidefsky <schwidefsky@...>, <linux-s390@...>, <tony.luck@...>, <linux-ia64@...>, <linux-arch@...>, <linux-kernel@...>
Date: Friday, March 28, 2008 - 8:53 pm

On Fri, 28 Mar 2008, Roland McGrath wrote:

Hmm. That probably means that TIF_RESTORE_SIGMASK shouldn't be a "TIF" 
flag at all, but a "TS" ("thread status") flag.

The TS flags are faster, because they are thread-synchronous and do not 
need atomic accesses (ie they are purely thread-local in setting, testing 
and clearing).

Of course, it may well not be worth it. Unlike the TIF flags, the TS flags 
have been architecture-specific and I don't think all architectures even 
do them (x86 uses them for FP state bits and stuff like that).

I guess TIF_RESTORE_SIGMASK is never *so* performance-critical that we'd 
care about the difference between a single cycle (approx) for a non-atomic 
"or" into memory and an atomic bitop (~50 cycles or so). 

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] set_restore_sigmask, Roland McGrath, (Fri Mar 28, 8:12 pm)
[PATCH 4/4] ia64 renumber TIF_RESTORE_SIGMASK, Roland McGrath, (Fri Mar 28, 8:14 pm)
[PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK, Roland McGrath, (Fri Mar 28, 8:14 pm)
Re: [PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK, Martin Schwidefsky, (Mon Mar 31, 3:53 am)
[PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Roland McGrath, (Fri Mar 28, 8:13 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Linus Torvalds, (Fri Mar 28, 8:53 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Oleg Nesterov, (Tue Apr 8, 7:35 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, David Woodhouse, (Wed Apr 9, 7:16 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Oleg Nesterov, (Wed Apr 9, 7:39 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, David Woodhouse, (Wed Apr 9, 12:14 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Oleg Nesterov, (Wed Apr 9, 12:22 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, David Woodhouse, (Wed Apr 9, 2:40 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Petr Tesarik, (Wed Apr 9, 8:57 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Roland McGrath, (Tue Apr 8, 3:51 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Linus Torvalds, (Tue Apr 8, 10:53 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Paul Mackerras, (Sun Mar 30, 6:53 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Roland McGrath, (Fri Mar 28, 10:24 pm)
[PATCH 1/2] HAVE_SET_RESTORE_SIGMASK, Roland McGrath, (Fri Mar 28, 11:14 pm)
[PATCH 2/2] x86 TS_RESTORE_SIGMASK, Roland McGrath, (Fri Mar 28, 11:14 pm)
Re: [PATCH 2/2] x86 TS_RESTORE_SIGMASK, Ingo Molnar, (Mon Mar 31, 9:01 am)
Re: [PATCH 2/2] x86 TS_RESTORE_SIGMASK, Roland McGrath, (Mon Mar 31, 3:30 pm)
[PATCH 1/2] HAVE_SET_RESTORE_SIGMASK, Roland McGrath, (Fri Mar 28, 11:11 pm)
Re: [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK, David Woodhouse, (Wed Apr 9, 7:45 am)
Re: [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK, Russell King, (Thu Apr 10, 4:32 pm)
Re: [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK, David Woodhouse, (Fri Apr 11, 9:40 am)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Linus Torvalds, (Fri Mar 28, 10:52 pm)
Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING, Roland McGrath, (Fri Mar 28, 11:12 pm)