login
Header Space

 
 

Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligned memory is bad

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>
Cc: Yasunori Goto <y-goto@...>, Ingo Molnar <mingo@...>, LKML <linux-kernel@...>, Rusty Russell <rusty@...>, Christoph Lameter <clameter@...>, Dave Hansen <dave@...>, Andrew Morton <akpm@...>
Date: Friday, March 28, 2008 - 5:30 pm

KAMEZAWA Hiroyuki wrote:

It seems the only in-tree user of the notifier is mm/slub.c, and it only 
cares about MEM_GOING_ONLINE, GOING_OFFLINE, OFFLINE and CANCEL_ONLINE 
(not ONLINE or CANCEL_OFFLINE).

Also,

	if (onlined_pages)
		memory_notify(MEM_ONLINE, &arg);

doesn't seem correct, because arg.nr_pages still has the original 
nr_pages, and not the number of pages actually onlined (onlined_pages).  
Also arg.start_pfn isn't terribly meaningful if a discontiguous set of 
pages can be actually onlined.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 4] [RFC] hotplug memory: minor updates, Jeremy Fitzhardinge, (Thu Mar 27, 8:28 pm)
Re: [PATCH 0 of 4] [RFC] hotplug memory: minor updates, Ingo Molnar, (Fri Mar 28, 5:12 am)
Re: [PATCH 0 of 4] [RFC] hotplug memory: minor updates, Jeremy Fitzhardinge, (Fri Mar 28, 12:07 pm)
Re: [PATCH 0 of 4] [RFC] hotplug memory: minor updates, Ingo Molnar, (Fri Mar 28, 6:04 pm)
[PATCH 2 of 4] hotplug-memory: adding non-section-aligned me..., Jeremy Fitzhardinge, (Thu Mar 27, 8:28 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., KAMEZAWA Hiroyuki, (Thu Mar 27, 9:27 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., KAMEZAWA Hiroyuki, (Thu Mar 27, 9:54 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Thu Mar 27, 10:13 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., KAMEZAWA Hiroyuki, (Thu Mar 27, 10:33 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Fri Mar 28, 5:30 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Thu Mar 27, 10:51 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Fri Mar 28, 12:07 am)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., KAMEZAWA Hiroyuki, (Thu Mar 27, 11:17 pm)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Fri Mar 28, 12:20 am)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., KAMEZAWA Hiroyuki, (Fri Mar 28, 12:39 am)
Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligne..., Jeremy Fitzhardinge, (Fri Mar 28, 2:19 pm)
[PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Jeremy Fitzhardinge, (Thu Mar 27, 8:28 pm)
Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Christoph Lameter, (Thu Mar 27, 8:35 pm)
Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Jeremy Fitzhardinge, (Thu Mar 27, 10:26 pm)
Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Christoph Lameter, (Thu Mar 27, 10:27 pm)
Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Jeremy Fitzhardinge, (Fri Mar 28, 2:18 am)
Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size, Jeremy Fitzhardinge, (Fri Mar 28, 2:05 pm)
[PATCH 4 of 4] paravirt_ops: don't steal memory resources in..., Jeremy Fitzhardinge, (Thu Mar 27, 8:28 pm)
[PATCH 1 of 4] hotplug-memory: add add_memory_resource, Jeremy Fitzhardinge, (Thu Mar 27, 8:28 pm)
speck-geostationary