On Fri, 28 Mar 2008, Pekka Enberg wrote:
quoted text
> 
> Because I didn't spot that we're calling kmalloc_large() in the fallback path
> too. I was referring to the page allocator pass-through kmalloc_large() call
> that happens before we hit __slab_alloc. My bad, sorry.

So this is kind of my point of the whole thing. It's really hard to even 
realize that there are multiple points - unless you do it at the top 
level.

And yeah, the double clearing is just a performance issue in a rare and 
odd case, and if it hadn't been for the very anal debug checks we would 
never have even noticed. But code that is hard to follow and has really 
subtle non-local implications is fundamentally more likely to have these 
kinds of problems. Which is why I'm arguing against code like that.

			Linus
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/