Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: <penberg@...>, <clameter@...>, <rjw@...>, <pstaszewski@...>, <linux-kernel@...>, <bunk@...>, <protasnb@...>
Date: Friday, March 28, 2008 - 2:47 pm

On Fri, 28 Mar 2008 11:20:52 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:


The bug we're discussing is http://bugzilla.kernel.org/show_bug.cgi?id=10318

It's a driver call stright into the page allocator - slab is not involved.

I was planning on plugging it this way:


From: Andrew Morton <akpm@linux-foundation.org>

I believe http://bugzilla.kernel.org/show_bug.cgi?id=10318 is a false
positive.  There's no way in which networking will be using highmem pages
here, so it won't be taking the KM_USER0 kmap slot, so there's no point in
performing these checks.

Cc: Pawel Staszewski <pstaszewski@artcom.pl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/x86/mm/highmem_32.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN arch/x86/mm/highmem_32.c~x86-kmap_atomic-debugging-only-run-debug_kmap_atomic_prot-for-highmem-pages arch/x86/mm/highmem_32.c
--- a/arch/x86/mm/highmem_32.c~x86-kmap_atomic-debugging-only-run-debug_kmap_atomic_prot-for-highmem-pages
+++ a/arch/x86/mm/highmem_32.c
@@ -73,15 +73,15 @@ void *kmap_atomic_prot(struct page *page
 {
 	enum fixed_addresses idx;
 	unsigned long vaddr;
-	/* even !CONFIG_PREEMPT needs this, for in_atomic in do_page_fault */
-
-	debug_kmap_atomic_prot(type);
 
+	/* even !CONFIG_PREEMPT needs this, for in_atomic in do_page_fault */
 	pagefault_disable();
 
 	if (!PageHighMem(page))
 		return page_address(page);
 
+	debug_kmap_atomic_prot(type);
+
 	idx = type + KM_TYPE_NR*smp_processor_id();
 	vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx);
 	BUG_ON(!pte_none(*(kmap_pte-idx)));
_

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Thu Mar 27, 6:53 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 6:24 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:12 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 12:18 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 6:58 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Peter Zijlstra, (Fri Mar 28, 7:00 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 7:13 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Peter Zijlstra, (Fri Mar 28, 7:44 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Thomas Gleixner, (Fri Mar 28, 7:16 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 7:31 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:17 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Fri Mar 28, 4:42 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 1:06 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Thu Mar 27, 10:30 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:10 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 12:47 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 6:28 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Mon Mar 31, 9:34 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Adrian Bunk, (Fri Mar 28, 1:36 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Ingo Molnar, (Fri Mar 28, 4:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Haavard Skinnemoen, (Fri Mar 28, 7:29 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 12:11 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Yinghai Lu, (Thu Mar 27, 11:31 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Kamalesh Babulal, (Mon Mar 31, 6:14 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Mon Mar 31, 8:10 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Thu Mar 27, 11:24 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 12:00 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:33 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:25 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Sat Mar 29, 4:42 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Sat Mar 29, 5:29 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Mon Mar 31, 2:45 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Sat Mar 29, 7:52 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Mon Mar 31, 2:56 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 1:15 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 1:27 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:32 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 2:08 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 2:20 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Pekka Enberg, (Fri Mar 28, 3:59 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 4:24 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Andrew Morton, (Fri Mar 28, 2:47 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:37 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Linus Torvalds, (Fri Mar 28, 3:59 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:53 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Christoph Lameter, (Fri Mar 28, 2:38 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Paweł Staszewski, (Fri Mar 28, 6:48 am)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Andrew Morton, (Fri Mar 28, 1:46 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 28, 5:57 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Carlos R. Mafra, (Thu Mar 27, 8:18 pm)
Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24, Rafael J. Wysocki, (Thu Mar 27, 8:23 pm)