Home » Mailing list archives » linux-kernel » 2008 » March » 28

Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <andi@...>
To: Ingo Molnar <mingo@...>
Cc: Pavel Machek <pavel@...>, Andi Kleen <andi@...>, kernel list <linux-kernel@...>
Subject: Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT
Date: Friday, March 28, 2008 - 10:25 am

> yes that is the theory - but how did your disk get corrupted in 

I suspect after wakeup due to the wrong ordering in resume (agp resume function
called too late).

The IOMMU code unfortunately doesn't know that the GART has gone away. 

The right fix for that is probably to move the GART resume code into
some shared file and make it a sysdev.

-Andi

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
agpgart: when telling user you'll corrupt his data, at least..., Pavel Machek, (Fri Mar 28, 7:25 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Ingo Molnar, (Fri Mar 28, 7:35 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Pavel Machek, (Fri Mar 28, 9:44 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Ingo Molnar, (Fri Mar 28, 10:13 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Pavel Machek, (Tue Apr 1, 8:13 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Andi Kleen, (Fri Mar 28, 10:25 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Jiri Kosina, (Fri Mar 28, 8:48 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Ingo Molnar, (Fri Mar 28, 8:51 am)
Re: agpgart: when telling user you'll corrupt his data, at l..., Andi Kleen, (Fri Mar 28, 7:35 am)
agpgart: scary messages are fortunately obsolete, Pavel Machek, (Tue Apr 1, 8:24 am)
Re: agpgart: scary messages are fortunately obsolete, Ingo Molnar, (Fri Apr 4, 4:55 am)
Re: agpgart: scary messages are fortunately obsolete, Andi Kleen, (Tue Apr 1, 9:33 am)