On Fri, 28 Mar 2008 16:45:28 +1100 NeilBrown <neilb@suse.de> wrote:
checkpatch 0.16 (which I misfiled and have thus far failed to merge up)
sayeth:
WARNING: consider using strict_strtoul in preference to simple_strtoul
#258: FILE: drivers/md/raid5.c:4090:
+ new = simple_strtoul(page, &end, 10);
the reason being that code which uses simple_strtoul() can treat
"42-what-a-todo" as "42", which seems a bit sloppy.
Your code won't have that failing, because it explicitly checks that the
input ended in \0 or \n. But strict_strtoul() internally does that, so this
open-coded test could be removed.
--