Re: [RFC] mmiotrace full patch, preview 2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Pekka Paalanen <pq@...>
Cc: <linux-kernel@...>, Ingo Molnar <mingo@...>, Christoph Hellwig <hch@...>, Arjan van de Ven <arjan@...>, Pavel Roskin <proski@...>, Steven Rostedt <rostedt@...>, Peter Zijlstra <a.p.zijlstra@...>
Date: Thursday, March 27, 2008 - 7:13 pm

Hi,

I may of course be wrong, but... Shouldn't the post_kmmio_handler(),
called from the die notifier chain, check for the DR_STEP condition?
This makes sure that the function is not called in the cases where the
source of the debug exception was not a single-stepping event. Though
I guess you'll also have other checks in place to notice that the
interrupt was not the one you were expecting. I guess a little extra
safety won't hurt though?

On Sun, Mar 9, 2008 at 3:40 PM, Pekka Paalanen <pq@iki.fi> wrote:

if (!(condition & DR_STEP))
    return;


Vegard
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] mmiotrace full patch, preview 2, Pekka Paalanen, (Sun Mar 9, 10:40 am)
mmiotrace bug: recursive probe hit, Pekka Paalanen, (Fri Mar 28, 4:25 pm)
Re: mmiotrace bug: recursive probe hit, Pekka Paalanen, (Sun Mar 30, 1:26 pm)
Re: mmiotrace bug: recursive probe hit, Pekka Paalanen, (Thu Apr 3, 5:07 pm)
Re: mmiotrace bug: recursive probe hit, Avi Kivity, (Sat Apr 5, 3:36 am)
Re: mmiotrace bug: recursive probe hit, Pekka Paalanen, (Sun Apr 6, 1:32 pm)
Re: mmiotrace bug: recursive probe hit, Pekka Enberg, (Sat Apr 5, 3:40 am)
Re: mmiotrace bug: recursive probe hit, Avi Kivity, (Sat Apr 5, 8:39 am)
Re: mmiotrace bug: recursive probe hit, Avi Kivity, (Sat Apr 5, 11:58 am)
Re: mmiotrace bug: recursive probe hit, Vegard Nossum, (Thu Apr 3, 5:40 pm)
Re: mmiotrace bug: recursive probe hit, Pekka Paalanen, (Fri Apr 4, 9:18 am)
Re: [RFC] mmiotrace full patch, preview 2, Vegard Nossum, (Thu Mar 27, 7:13 pm)
Re: [RFC] mmiotrace full patch, preview 2, Pekka Paalanen, (Fri Mar 28, 2:24 pm)
Re: [RFC] mmiotrace full patch, preview 2, Pekka Paalanen, (Sun Mar 9, 10:46 am)