On Thu, 27 Mar 2008, Ingo Molnar wrote:... Ingo, this patch makes no sense. Two reasons: - "error_code & 16" is senseless. Use PF_INSTR instead, which actually tells the reader something. - this piece of crap code is immediately followed by /* If it was a exec fault on NX page, ignore */ if (error_code & PF_INSTR) return 0; which uses that *right* and readable PF_INSTR #define, and also shows that the newly modified code is totally insane (ie: if the new code triggers, then it would have returned 0 later _anyway_) So I think it's just crap. I think it's duplication from the merging of the x86 code, and I think that the fact that the new code didn't use the right #define helper means that people didn't see that it was crap. I pulled it, but this needs some resolution. The code makes no sense. Should that #ifdef and the code inside of it just be removed entirely? Linus --
| Bron Gondwana | BUG: mmapfile/writev spurious zero bytes (x86_64/not i386, bisected, reproducable) |
| Gabriel C | Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS] |
| David Miller | [GIT]: Networking |
| Dave Young | Re: 2.6.24-rc3-mm1 |
git: | |
| Matthieu Moy | git push to a non-bare repository |
| Josh Boyer | git-unpack-objects |
| Linus Torvalds | Re: Problem with a push |
| Johannes Schindelin | Re: Git-windows and git-svn? |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| James | Re: OBSD on MacBook |
| Alexey Suslikov | OT: OpenBSD on Asus eeePC |
| Daniel Ouellet | Re: Show your appreciation and get your 4.2 DVD |
| David Pottage | Re: My experience with the Freerunner |
| "Marco Trevisan (Treviño)" | Re: Car charger to GTA02 |
| Neng-Yu Tu (Tony Tu) | GTA02 GPS rework for SD card interference issue |
| Christ van Willegen | Public build host (proposal) |
| Linux Bootup hangs after adding RealTime Premption and HR-Timer | 0 minutes ago | Linux kernel |
| SATA 2 size problems | 59 minutes ago | Windows |
| problem with 2.6 kernel driver for a USB MAG Stripe Reader as HID device. | 13 hours ago | Linux kernel |
| get_user_pages failure | 15 hours ago | Linux kernel |
| Reading linux kernel | 16 hours ago | Linux kernel |
| High level of Seagate 2.5" SATA drives failing | 22 hours ago | Hardware |
| Resetting the bios password for Toshiba Laptop | 1 day ago | Hardware |
| Linux 2.6.22 slowly RUNS OUT OF LOWMEM | 1 day ago | Linux kernel |
| Questions about modules | 1 day ago | Linux kernel |
| KDB | 2 days ago | Linux kernel |
