Re: [git pull] x86 fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Thursday, March 27, 2008 - 1:31 pm

On Thu, 27 Mar 2008, Ingo Molnar wrote:
...

Ingo, this patch makes no sense.

Two reasons:

 - "error_code & 16" is senseless. Use PF_INSTR instead, which actually 
   tells the reader something.

 - this piece of crap code is immediately followed by

	/* If it was a exec fault on NX page, ignore */
	if (error_code & PF_INSTR)
		return 0;

   which uses that *right* and readable PF_INSTR #define, and also shows 
   that the newly modified code is totally insane (ie: if the new code 
   triggers, then it would have returned 0 later _anyway_)

So I think it's just crap. I think it's duplication from the merging of 
the x86 code, and I think that the fact that the new code didn't use the 
right #define helper means that people didn't see that it was crap.

I pulled it, but this needs some resolution. The code makes no sense. 
Should that #ifdef and the code inside of it just be removed entirely?

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] x86 fixes, Ingo Molnar, (Thu Mar 27, 1:03 pm)
Re: [git pull] x86 fixes, Linus Torvalds, (Thu Mar 27, 1:31 pm)
Re: [git pull] x86 fixes, Harvey Harrison, (Thu Mar 27, 1:48 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Thu Mar 27, 1:50 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Thu Mar 27, 1:55 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Thu Mar 27, 2:01 pm)
Re: [git pull] x86 fixes, Harvey Harrison, (Thu Mar 27, 2:08 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Thu Mar 27, 2:24 pm)