On Tue, 25 Mar 2008 16:27:17 -0500 York Sun <yorksun@freescale.com> wrote:

quoted text
> +#if defined(CONFIG_NOT_COHERENT_CACHE)
> +unsigned int *coherence_data;
> +phys_addr_t *coherence_data_phy;
> +#endif

These identifiers are too general for use as global symbols.  I'd suggest
renaming them to diu_coherence_data and diu_coherence_data_phy.  Or make
them static - I didn't check.

I'll duck this version of the patches, as Scott's comments looked rather
substantial.

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/