login
Header Space

 
 

Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: York Sun <yorksun@...>
Cc: <linux-fbdev-devel@...>, <linux-kernel@...>, <linuxppc-dev@...>, <galak@...>, <a.p.zijlstra@...>, Timur Tabi <timur@...>
Date: Thursday, March 27, 2008 - 3:54 am

On Tue, 25 Mar 2008 16:27:17 -0500 York Sun <yorksun@freescale.com> wrote:


These identifiers are too general for use as global symbols.  I'd suggest
renaming them to diu_coherence_data and diu_coherence_data_phy.  Or make
them static - I didn't check.

I'll duck this version of the patches, as Scott's comments looked rather
substantial.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
V3 Patch - Driver for Freescale 8610 and 5121 DIU, York Sun, (Tue Mar 25, 5:27 pm)
Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU, Andrew Morton, (Thu Mar 27, 3:54 am)
speck-geostationary